8294262: AArch64: compiler/vectorapi/TestReverseByteTransforms.java test failed on SVE machine #10442

e1iu · 2022-09-27T09:31:43Z

This test failed at cases test_reversebytes_short/int/long_transform2, which expected the ReversBytesV node, but nothing was finally found. On SVE system, we have a specific optimization, ReverseBytesV (ReverseBytesV X MASK) MASK => X, which eliminates both ReverseBytesV nodes. This optimization rule is specifically on hardware with native predicate support. See #9623 for more details.

As there is an SVE specific case TestReverseByteTransformsSVE.java, this patch simply marks TestReverseByteTransforms.java as non-SVE only.

[TEST]
jdk/incubator/vector, hotspot/compiler/vectorapi pass on SVE machine

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8294262: AArch64: compiler/vectorapi/TestReverseByteTransforms.java test failed on SVE machine

Reviewers

Andrew Haley (@theRealAph - Reviewer)
Ningsheng Jian (@nsjian - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10442/head:pull/10442
$ git checkout pull/10442

Update a local copy of the PR:
$ git checkout pull/10442
$ git pull https://git.openjdk.org/jdk pull/10442/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10442

View PR using the GUI difftool:
$ git pr show -t 10442

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10442.diff

…est failed on SVE machine This test failed at cases test_reversebytes_short/int/long_transform2, which expected the ReversBytesV node, but nothing was finally found. On SVE system, we have a specific optimization, ReverseBytesV (ReverseBytesV X MASK) MASK => X, which eliminates both ReverseBytesV nodes. This optimization rule is specifically on hardware with native predicate support. See openjdk#9623 for more details. As there is an SVE specific case TestReverseByteTransformsSVE.java, this patch simply marks TestReverseByteTransforms.java as non-SVE only. [TEST] jdk/incubator/vector, hotspot/compiler/vectorapi pass on SVE machine Change-Id: I48877cbe89e50ee5afff51b300a503e7931e28ec

bridgekeeper · 2022-09-27T09:33:50Z

👋 Welcome back eliu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-09-27T09:36:49Z

@theRealELiu The following label will be automatically applied to this pull request:

hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-09-27T09:40:57Z

Webrevs

01: Full - Incremental (d3aa14e6)
00: Full (cf4d967d)

theRealAph · 2022-09-27T10:00:22Z

test/hotspot/jtreg/compiler/vectorapi/TestReverseByteTransforms.java

@@ -39,6 +39,7 @@
 * @bug 8287794
 * @summary Test various reverse bytes ideal transforms on X86(AVX2, AVX512) and AARCH64(NEON)
 * @requires vm.compiler2.enabled
+ * @requires !(vm.cpu.features ~= ".*sve.*")


Please add a comment such as:
"On SVE system, we have a specific optimization, ReverseBytesV (ReverseBytesV X MASK) MASK => X, which eliminates both ReverseBytesV nodes. This optimization rule is specifically on hardware with native predicate support.
There is an SVE specific case TestReverseByteTransformsSVE.java, so this patch simply marks TestReverseByteTransforms.java as non-SVE only.

Change-Id: I4c17256ff656528bbcfcacd2ee2380df6ae14bf1

openjdk · 2022-10-10T13:33:07Z

@theRealELiu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294262: AArch64: compiler/vectorapi/TestReverseByteTransforms.java test failed on SVE machine

Reviewed-by: aph, njian

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 239 new commits pushed to the master branch:

4b17d28: 8294261: AArch64: Use pReg instead of pRegGov when possible
891156a: 8295003: Do not mention applets in the "java.awt.color" package
e6c33e6: 8295014: Remove unnecessary explicit casts to void* in CHeapObjBase
1bfcc27: 8294931: JFR: Simplify SettingInfo
eb90c4f: 8294377: Prepare to stop auto-inheriting documentation for subclasses of exceptions whose documentation is inherited
4df4a1f: 8287832: jdk/jfr/event/runtime/TestActiveSettingEvent.java failed with "Expected two batches of Active Setting events"
35d17a0: 8293864: Kitchensink24HStress.java fails with SIGSEGV in JfrCheckpointManager::lease
c5f462e: 8294956: GHA: qemu-debootstrap is deprecated, use the regular one
269252a: 8295007: javax/swing/JRadioButton/4314194/bug4314194.java fails in mach5 for WIndowLookAndFeel
6ed74ef: 8295005: compiler/loopopts/TestRemoveEmptyLoop.java fails with release VMs after JDK-8294839
... and 229 more: https://git.openjdk.org/jdk/compare/379f3094db0b8afe90ed6b7a341164222744085f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

nsjian

Looks good.

e1iu · 2022-10-11T01:35:45Z

/integrate

openjdk · 2022-10-11T01:37:29Z

Going to push as commit 9d116ec.
Since your change was applied there have been 239 commits pushed to the master branch:

4b17d28: 8294261: AArch64: Use pReg instead of pRegGov when possible
891156a: 8295003: Do not mention applets in the "java.awt.color" package
e6c33e6: 8295014: Remove unnecessary explicit casts to void* in CHeapObjBase
1bfcc27: 8294931: JFR: Simplify SettingInfo
eb90c4f: 8294377: Prepare to stop auto-inheriting documentation for subclasses of exceptions whose documentation is inherited
4df4a1f: 8287832: jdk/jfr/event/runtime/TestActiveSettingEvent.java failed with "Expected two batches of Active Setting events"
35d17a0: 8293864: Kitchensink24HStress.java fails with SIGSEGV in JfrCheckpointManager::lease
c5f462e: 8294956: GHA: qemu-debootstrap is deprecated, use the regular one
269252a: 8295007: javax/swing/JRadioButton/4314194/bug4314194.java fails in mach5 for WIndowLookAndFeel
6ed74ef: 8295005: compiler/loopopts/TestRemoveEmptyLoop.java fails with release VMs after JDK-8294839
... and 229 more: https://git.openjdk.org/jdk/compare/379f3094db0b8afe90ed6b7a341164222744085f...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-10-11T01:37:41Z

@theRealELiu Pushed as commit 9d116ec.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk bot added the rfr Pull request is ready for review label Sep 27, 2022

openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Sep 27, 2022

theRealAph reviewed Sep 27, 2022

View reviewed changes

add comment

d3aa14e

Change-Id: I4c17256ff656528bbcfcacd2ee2380df6ae14bf1

e1iu requested a review from theRealAph October 6, 2022 13:10

theRealAph approved these changes Oct 10, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 10, 2022

nsjian approved these changes Oct 11, 2022

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Oct 11, 2022

openjdk bot closed this Oct 11, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 11, 2022

e1iu deleted the fix-test-reverse branch July 10, 2023 09:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

8294262: AArch64: compiler/vectorapi/TestReverseByteTransforms.java test failed on SVE machine #10442

8294262: AArch64: compiler/vectorapi/TestReverseByteTransforms.java test failed on SVE machine #10442

Uh oh!

e1iu commented Sep 27, 2022 •

edited by openjdk bot

Loading

Uh oh!

bridgekeeper bot commented Sep 27, 2022

Uh oh!

openjdk bot commented Sep 27, 2022

Uh oh!

mlbridge bot commented Sep 27, 2022 •

edited

Loading

Uh oh!

theRealAph Sep 27, 2022

Uh oh!

openjdk bot commented Oct 10, 2022 •

edited

Loading

Uh oh!

nsjian left a comment

Uh oh!

e1iu commented Oct 11, 2022

Uh oh!

openjdk bot commented Oct 11, 2022

Uh oh!

openjdk bot commented Oct 11, 2022

Uh oh!

Uh oh!

8294262: AArch64: compiler/vectorapi/TestReverseByteTransforms.java test failed on SVE machine #10442

8294262: AArch64: compiler/vectorapi/TestReverseByteTransforms.java test failed on SVE machine #10442

Uh oh!

Conversation

e1iu commented Sep 27, 2022 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Sep 27, 2022

Uh oh!

openjdk bot commented Sep 27, 2022

Uh oh!

mlbridge bot commented Sep 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

theRealAph Sep 27, 2022

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Oct 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nsjian left a comment

Choose a reason for hiding this comment

Uh oh!

e1iu commented Oct 11, 2022

Uh oh!

openjdk bot commented Oct 11, 2022

Uh oh!

openjdk bot commented Oct 11, 2022

Uh oh!

Uh oh!

e1iu commented Sep 27, 2022 •

edited by openjdk bot

Loading

mlbridge bot commented Sep 27, 2022 •

edited

Loading

openjdk bot commented Oct 10, 2022 •

edited

Loading