Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8294460: CodeSection::alignment checks for CodeBuffer::SECT_STUBS incorrectly #10450

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Sep 27, 2022

Code added in CodeSection::alignment by JDK-8287373 triggers -Wint-in-bool-context warning on GCC (currently globally ignored), due to apparent bug.

The bug seems innocuous now, as the branch is always taken, and the method checks for the rest of section types exhaustively. But, it would not go to ShouldNotReachHere if we pass e.g. SECT_NONE into the method.

Attention @bulasevich.

Additional testing:

  • Linux x86_64 fastdebug tier1

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8294460: CodeSection::alignment checks for CodeBuffer::SECT_STUBS incorrectly

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10450/head:pull/10450
$ git checkout pull/10450

Update a local copy of the PR:
$ git checkout pull/10450
$ git pull https://git.openjdk.org/jdk pull/10450/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10450

View PR using the GUI difftool:
$ git pr show -t 10450

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10450.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 27, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 27, 2022
@openjdk
Copy link

openjdk bot commented Sep 27, 2022

@shipilev The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Sep 27, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 27, 2022

Webrevs

@shipilev
Copy link
Member Author

Withdrawn, because testing shows there is a subtler issue in it. I added the failure example to the bug and reassigned to @bulasevich.

@shipilev shipilev closed this Sep 27, 2022
@shipilev shipilev deleted the JDK-8294460-cs-align-wrong branch October 21, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org rfr Pull request is ready for review
1 participant