Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8293969: breakup the long signature in SystemDictionaryShared::is_supported_invokedynamic #10452

Closed
wants to merge 1 commit into from

Conversation

matias9927
Copy link
Contributor

@matias9927 matias9927 commented Sep 27, 2022

Broke up signature into three lines. Tested with tier 1. Please review


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8293969: breakup the long signature in SystemDictionaryShared::is_supported_invokedynamic

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10452/head:pull/10452
$ git checkout pull/10452

Update a local copy of the PR:
$ git checkout pull/10452
$ git pull https://git.openjdk.org/jdk pull/10452/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10452

View PR using the GUI difftool:
$ git pr show -t 10452

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10452.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 27, 2022

👋 Welcome back matias9927! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 27, 2022

@matias9927 The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Sep 27, 2022
@matias9927 matias9927 marked this pull request as ready for review September 28, 2022 13:20
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 28, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 28, 2022

Webrevs

Copy link
Member

@eastig eastig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Trivial, can be pushed today!

@openjdk
Copy link

openjdk bot commented Sep 29, 2022

@matias9927 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293969: breakup the long signature in SystemDictionaryShared::is_supported_invokedynamic

Reviewed-by: eastigeevich, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 63 new commits pushed to the master branch:

  • aeef3ec: 8294198: Implement isFinite intrinsic for RISC-V
  • 5f6ad92: 8294547: HotSpotAgent.setupVM() should include "cause" exception when throwing DebuggerException
  • 545ded1: 8294548: Problem list SA core file tests on macosx-x64 due to JDK-8294316
  • 29c70f1: 8294595: Add javax/swing/plaf/aqua/CustomComboBoxFocusTest.java to problem list
  • 5d48da4: 8294370: Fix allocation bug in java_lang_Thread::async_get_stack_trace()
  • ce85cac: 8065554: MatchResult should provide values of named-capturing groups
  • 1decdce: 8294492: RISC-V: Use li instead of patchable movptr at non-patchable callsites
  • 8491fd5: 8294551: Put java/io/BufferedInputStream/TransferTo.java on problem list
  • 6f8f28e: 8294160: misc crash dump improvements
  • 8873192: 8293515: heapShared.cpp: rename JavaThread parameter to current
  • ... and 53 more: https://git.openjdk.org/jdk/compare/543851db926469df57a8f4a2bd3458349012145f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@eastig, @coleenp) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 29, 2022
@matias9927
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 29, 2022
@openjdk
Copy link

openjdk bot commented Sep 29, 2022

@matias9927
Your change (at version bd8d191) is now ready to be sponsored by a Committer.

@coleenp
Copy link
Contributor

coleenp commented Sep 29, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 29, 2022

Going to push as commit 88062ee.
Since your change was applied there have been 63 commits pushed to the master branch:

  • aeef3ec: 8294198: Implement isFinite intrinsic for RISC-V
  • 5f6ad92: 8294547: HotSpotAgent.setupVM() should include "cause" exception when throwing DebuggerException
  • 545ded1: 8294548: Problem list SA core file tests on macosx-x64 due to JDK-8294316
  • 29c70f1: 8294595: Add javax/swing/plaf/aqua/CustomComboBoxFocusTest.java to problem list
  • 5d48da4: 8294370: Fix allocation bug in java_lang_Thread::async_get_stack_trace()
  • ce85cac: 8065554: MatchResult should provide values of named-capturing groups
  • 1decdce: 8294492: RISC-V: Use li instead of patchable movptr at non-patchable callsites
  • 8491fd5: 8294551: Put java/io/BufferedInputStream/TransferTo.java on problem list
  • 6f8f28e: 8294160: misc crash dump improvements
  • 8873192: 8293515: heapShared.cpp: rename JavaThread parameter to current
  • ... and 53 more: https://git.openjdk.org/jdk/compare/543851db926469df57a8f4a2bd3458349012145f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 29, 2022
@openjdk openjdk bot closed this Sep 29, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 29, 2022
@openjdk
Copy link

openjdk bot commented Sep 29, 2022

@coleenp @matias9927 Pushed as commit 88062ee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants