Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8294467: Fix sequence-point warnings in Hotspot #10454

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Sep 27, 2022

There seem to be the only place in Hotspot where this warning fires, yet the warning is disabled wholesale for Hotspot. This is not good.

I can trace the addition of sequence-point exclusion to JDK-8211029 (Sep 2018), yet the only place where it triggers introduced by JDK-8259609 (Oct 2021). It seems other places were fixed meanwhile.

I believe the fixed place is just a simple leftover. Right, @rwestrel?

Additional testing:

  • Linux x86_64 fastdebug tier1
  • Linux x86_64 fastdebug tier2
  • The build matrix of:
    • GCC 10
    • {i686, x86_64, aarch64, powerpc64le, s390x, armhf, riscv64}
    • {server}
    • {release, fastdebug}

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10454/head:pull/10454
$ git checkout pull/10454

Update a local copy of the PR:
$ git checkout pull/10454
$ git pull https://git.openjdk.org/jdk pull/10454/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10454

View PR using the GUI difftool:
$ git pr show -t 10454

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10454.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 27, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 27, 2022
@openjdk
Copy link

openjdk bot commented Sep 27, 2022

@shipilev The following labels will be automatically applied to this pull request:

  • build
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build build-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org labels Sep 27, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 27, 2022

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Thanks

@openjdk
Copy link

openjdk bot commented Sep 28, 2022

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294467: Fix sequence-point warnings in Hotspot

Reviewed-by: dholmes, thartmann, roland

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • b269c51: 8295395: Linux Alpha Zero builds fail after JDK-8292591
  • ae60599: 8295023: Interpreter(AArch64): Implement -XX:+PrintBytecodeHistogram and -XX:+PrintBytecodePairHistogram options

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 28, 2022
Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'll run this through our testing, just to make sure.

Copy link
Contributor

@rwestrel rwestrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@TobiHartmann
Copy link
Member

All tests passed.

@shipilev
Copy link
Member Author

Thank you all!

/integrate

@openjdk
Copy link

openjdk bot commented Oct 19, 2022

Going to push as commit 388a56e.
Since your change was applied there have been 56 commits pushed to the master branch:

  • ceb5b08: 8294468: Fix char-subscripts warnings in Hotspot
  • 7b1c676: 8295662: jdk/incubator/vector tests fail "assert(VM_Version::supports_avx512vlbw()) failed"
  • 5eaf568: 8295668: validate-source failure after JDK-8290011
  • e238920: 8295372: CompactNumberFormat handling of number one with decimal part
  • a5f6e31: 8295456: (ch) sun.nio.ch.Util::checkBufferPositionAligned gives misleading/incorrect error
  • e27bea0: 8290011: IGV: Remove dead code and cleanup
  • d37ce4c: 8290368: Introduce LDAP and RMI protocol-specific object factory filters to JNDI implementation
  • 21aeb9e: 8295429: Update harfbuzz md file
  • 1d883c5: 8295417: Pass $AR to binutils cross-build
  • fc88957: 8286707: JFR: Don't commit JFR internal jdk.JavaMonitorWait events
  • ... and 46 more: https://git.openjdk.org/jdk/compare/4d37ef2d545c016e6c3ad52171ea961d4406726f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 19, 2022
@openjdk openjdk bot closed this Oct 19, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 19, 2022
@openjdk
Copy link

openjdk bot commented Oct 19, 2022

@shipilev Pushed as commit 388a56e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8294467-warning-sequence-point branch October 21, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
4 participants