8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException

[plummercj]

JDK-8293563 is due to a macOS bug (or maybe a feature) that is resulting in the java heap not always being present in the core file. Running with -XX:+AlwaysPreTouch seems to work around this problem. This issue is only on macosx-aarch64, not x64.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer)
• Kevin Walls (@kevinjwalls - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10458/head:pull/10458
$ git checkout pull/10458

Update a local copy of the PR:
$ git checkout pull/10458
$ git pull https://git.openjdk.org/jdk pull/10458/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10458

View PR using the GUI difftool:
$ git pr show -t 10458

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10458.diff

[bridgekeeper]

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@plummercj The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (114acc06)

[sspitsyn]

Looks good.
Thanks,
Serguei

[sspitsyn]

I see, 8269982 removed in problem list is a dup of 8293563.

[openjdk]

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException

Reviewed-by: sspitsyn, kevinw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 41 new commits pushed to the master branch:

• 60616f2: 8294059: Serial: Refactor GenCollectedHeap::collect
• ea61671: 8294359: Interpreter(AArch64) intrinsify Thread.currentThread()
• c42ef70: 7148092: [macosx] When Alt+down arrow key is pressed, the combobox popup does not appear.
• 94e14da: 8294057: Parallel: Tighten ParallelCompactData::initialize_region_data
• 1ea0d6b: 8292301: [REDO v2] C2 crash when allocating array of size too large
• c13e0ef: 8292848: AWT_Mixing and TrayIcon tests fail on el8 with hard-coded isOel7
• 79ccc79: 8293613: need to properly handle and hide tmp VTMS transitions
• 5e1e449: 8290920: sspi_bridge.dll not built if BUILD_CRYPTO is false
• d827fd8: 8294430: RISC-V: Small refactoring for movptr_with_offset
• 9d76ac8: 8292158: AES-CTR cipher state corruption with AVX-512
• ... and 31 more: https://git.openjdk.org/jdk/compare/169a5d48afbc6627f36a768c17c2a5e56219d9c7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[plummercj]

Thanks, Serguei and Kevin!

/integrate

[openjdk]

Going to push as commit 76f1865.
Since your change was applied there have been 50 commits pushed to the master branch:

• 9db95ed: 8215788: Clarify JarInputStream Manifest access
• 9309786: 8294472: Remove redundant rawtypes suppression in AbstractChronology
• 3b7fc80: 8294411: SA should provide more useful info when it fails to start up due to "failed to workaround classshareing"
• 4fb424b: 8293961: Unused ClassPathZipEntry::contents_do
• 7515b30: 8279283: BufferedInputStream should override transferTo
• 7401fe0: 8292912: Make guard card in CardTable inaccessible
• 70d8428: 8294520: Problemlist java/nio/file/Files/CopyProcFile.java
• 30e3bf9: 8291805: IGV: Improve Zooming
• 37f83b9: 8294375: test/jdk/java/nio/channels/vthread/BlockingChannelOps.java is slow
• 60616f2: 8294059: Serial: Refactor GenCollectedHeap::collect
• ... and 40 more: https://git.openjdk.org/jdk/compare/169a5d48afbc6627f36a768c17c2a5e56219d9c7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@plummercj Pushed as commit 76f1865.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.