8225235: Unused field defaultIndex in NetworkInterface

[viktorklang-ora]

Removes the defaultIndexsince it is no longer used.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8225235: Unused field defaultIndex in NetworkInterface

Reviewers

• Chris Hegarty (@ChrisHegarty - Reviewer) ⚠️ Review applies to 3a9fe9ac
• Vyom Tewari (@vyommani - Committer) ⚠️ Review applies to 3a9fe9ac
• Daniel Fuchs (@dfuch - Reviewer) ⚠️ Review applies to 3a9fe9ac
• Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10471/head:pull/10471
$ git checkout pull/10471

Update a local copy of the PR:
$ git checkout pull/10471
$ git pull https://git.openjdk.org/jdk pull/10471/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10471

View PR using the GUI difftool:
$ git pr show -t 10471

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10471.diff

[bridgekeeper]

Hi @viktorklang-ora, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user viktorklang-ora" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

@viktorklang-ora The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[viktorklang-ora]

/covered

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[mlbridge]

Webrevs

• 01: Full - Incremental (3e7a253b)
• 00: Full (3a9fe9ac)

[jaikiran]

Hello Viktor, the change looks OK to me. For the NetworkInterface.java file change, could you also update the copyright year from the current 2000, 2021, to 2000, 2022,?

[ChrisHegarty]

LGTM

[openjdk]

⚠️ @viktorklang-ora the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 8225235
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

[openjdk]

@viktorklang-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8225235: Unused field defaultIndex in NetworkInterface

Reviewed-by: chegar, vtewari, dfuchs, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 65 new commits pushed to the master branch:

• ce85cac: 8065554: MatchResult should provide values of named-capturing groups
• 1decdce: 8294492: RISC-V: Use li instead of patchable movptr at non-patchable callsites
• 8491fd5: 8294551: Put java/io/BufferedInputStream/TransferTo.java on problem list
• 6f8f28e: 8294160: misc crash dump improvements
• 8873192: 8293515: heapShared.cpp: rename JavaThread parameter to current
• 76f1865: 8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException
• 9db95ed: 8215788: Clarify JarInputStream Manifest access
• 9309786: 8294472: Remove redundant rawtypes suppression in AbstractChronology
• 3b7fc80: 8294411: SA should provide more useful info when it fails to start up due to "failed to workaround classshareing"
• 4fb424b: 8293961: Unused ClassPathZipEntry::contents_do
• ... and 55 more: https://git.openjdk.org/jdk/compare/acd75e0f1cddf8307bf0ef4f95a6f11051c30bc2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@ChrisHegarty, @vyommani, @dfuch, @jaikiran) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[vyommani]

Looks OK to me.

[dfuch]

Please update copyright years in NetworkInterface.java. Otherwise LGTM!

[viktorklang-ora]

@dfuch @vyommani @ChrisHegarty Commit added which updates copyright year to 2022 in NetworkInterface.java 👍

[dfuch]

Thanks! Please integrate and one of us will sponsor.

[viktorklang-ora]

/integrate

[openjdk]

@viktorklang-ora
Your change (at version 3e7a253) is now ready to be sponsored by a Committer.

[jaikiran]

I'll run our internal CI tests to be sure nothing breaks, before sponsoring this.

[jaikiran]

The relevant tests in tier1, tier2 and tier3 completed without any failures.

[jaikiran]

/sponsor

[openjdk]

Going to push as commit b030c7d.
Since your change was applied there have been 72 commits pushed to the master branch:

• a07975b: 8294519: (fs) java/nio/file/Files/CopyProcFile.java fails intermittenly due to unstable /proc/cpuinfo output
• 88062ee: 8293969: breakup the long signature in SystemDictionaryShared::is_supported_invokedynamic
• aeef3ec: 8294198: Implement isFinite intrinsic for RISC-V
• 5f6ad92: 8294547: HotSpotAgent.setupVM() should include "cause" exception when throwing DebuggerException
• 545ded1: 8294548: Problem list SA core file tests on macosx-x64 due to JDK-8294316
• 29c70f1: 8294595: Add javax/swing/plaf/aqua/CustomComboBoxFocusTest.java to problem list
• 5d48da4: 8294370: Fix allocation bug in java_lang_Thread::async_get_stack_trace()
• ce85cac: 8065554: MatchResult should provide values of named-capturing groups
• 1decdce: 8294492: RISC-V: Use li instead of patchable movptr at non-patchable callsites
• 8491fd5: 8294551: Put java/io/BufferedInputStream/TransferTo.java on problem list
• ... and 62 more: https://git.openjdk.org/jdk/compare/acd75e0f1cddf8307bf0ef4f95a6f11051c30bc2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jaikiran @viktorklang-ora Pushed as commit b030c7d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.