Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8288907: serviceability/jvmti/vthread/SuspendResume1/SuspendResume1.java fails with -XX:TieredStopAtLevel=2,3 #10480

Closed
wants to merge 1 commit into from

Conversation

sspitsyn
Copy link
Contributor

@sspitsyn sspitsyn commented Sep 29, 2022

The test SuspendResume fails on linux-aarch64 with timeouts.
However, it never fails when test timeout is set to a bigger value:

diff --git a/test/hotspot/jtreg/serviceability/jvmti/vthread/SuspendResume1/SuspendResume1.java b/test/hotspot/jtreg/serviceability/jvmti/vthread/SuspendResume1/SuspendResume1.java
index cd5b8251fce..562f2eae921 100644
--- a/test/hotspot/jtreg/serviceability/jvmti/vthread/SuspendResume1/SuspendResume1.java
+++ b/test/hotspot/jtreg/serviceability/jvmti/vthread/SuspendResume1/SuspendResume1.java
@@ -29,7 +29,7 @@
  * @library /test/lib
  * @compile --enable-preview -source ${jdk.version} SuspendResume1.java
  * @run driver jdk.test.lib.FileInstaller . .
- * @run main/othervm/native
+ * @run main/othervm/native/timeout=600
  *      --enable-preview
  *      -Djava.util.concurrent.ForkJoinPool.common.parallelism=1
  *      -agentlib:SuspendResume1

I'd like to push this as a trivial fix.

Testing: Submitted mach5 test runs on multiple platforms.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8288907: serviceability/jvmti/vthread/SuspendResume1/SuspendResume1.java fails with -XX:TieredStopAtLevel=2,3

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10480/head:pull/10480
$ git checkout pull/10480

Update a local copy of the PR:
$ git checkout pull/10480
$ git pull https://git.openjdk.org/jdk pull/10480/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10480

View PR using the GUI difftool:
$ git pr show -t 10480

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10480.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 29, 2022

👋 Welcome back sspitsyn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 29, 2022
@openjdk
Copy link

openjdk bot commented Sep 29, 2022

@sspitsyn The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Sep 29, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 29, 2022

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine and trivial to me.

Thanks.

@openjdk
Copy link

openjdk bot commented Sep 29, 2022

@sspitsyn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288907: serviceability/jvmti/vthread/SuspendResume1/SuspendResume1.java fails with -XX:TieredStopAtLevel=2,3

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 1decdce: 8294492: RISC-V: Use li instead of patchable movptr at non-patchable callsites

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 29, 2022
@plummercj
Copy link
Contributor

I'm not so sure increasing the timeout is the right thing to do. Here are the results of running 5 times on each of our 5 platforms with -XX:TieredStopAtLevel=2"

macosx-aarch64-debug 22s
windows-x64-debug 23s
windows-x64-debug 23s
macosx-aarch64-debug 23s
macosx-aarch64-debug 24s
macosx-aarch64-debug 24s
windows-x64-debug 24s
macosx-x64-debug 24s
macosx-aarch64-debug 25s
macosx-x64-debug 26s
macosx-x64-debug 26s
macosx-x64-debug 26s
macosx-x64-debug 26s
windows-x64-debug 28s
windows-x64-debug 33s
linux-x64-debug 43s
linux-x64-debug 45s
linux-aarch64-debug 2m 17s
linux-x64-debug 2m 20s
linux-x64-debug 2m 42s
linux-x64-debug 2m 59s
linux-aarch64-debug 3m 22s
linux-aarch64-debug 4m 31s
linux-aarch64-debug 6m 30s
linux-aarch64-debug 9m 22s

The last one was a timeout. So it seems that linux-aarch64 is consistently slow. linux-x64 is also a bit slow in some cases. It seems it would be worth understanding these performance differences.

@plummercj
Copy link
Contributor

I also tried the same with product builds. linux-aarch64 got worse, with 4 out of 5 timing out. linux-x64 improved with only one run over 1m.

@sspitsyn
Copy link
Contributor Author

Thank you for the comment, Chris. I agree, this test is executed on linux-aarch64 much slower than on other platforms. Now, I can move this bug to the Compiler team plate or push my fix and open a Compiler bug separately. It feels like you prefer the former.

@sspitsyn
Copy link
Contributor Author

sspitsyn commented Oct 3, 2022

I've filed a separate JBS issue about C1 compiler performance on linux-aarch64:
https://bugs.openjdk.org/browse/JDK-8294741:
poor C1 performance on linux-aarch64 with VM option -XX:TieredStopAtLevel=2,3

@sspitsyn
Copy link
Contributor Author

sspitsyn commented Oct 3, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 3, 2022

Going to push as commit 07ed68e.
Since your change was applied there have been 49 commits pushed to the master branch:

  • 090cdfc: 8294726: Update URLs in minefield tests
  • ed40d88: 8276849: Refresh the window icon on graphics configuration changes
  • 081691a: 8294593: Check the size of the target on invocations of BigInteger::isProbablePrime
  • a4f2078: 8294437: java/nio/channels/FileChannel tests slow on Windows
  • c6e3daa: 8242115: C2 SATB barriers are not safepoint-safe
  • e137f9f: 8293877: Rewrite MineField test
  • 4f44fd6: 8237467: jlink plugin to save the argument files as input to jlink in the output image
  • edfb18a: 8294695: Remove redundant deprecation suppression in ThreadGroup
  • 46633e6: 8294698: Remove unused 'checkedExceptions' param from MethodAccessorGenerator.generateMethod()
  • f2a32d9: 8293691: converting a defined BasicType value to a string should not crash the VM
  • ... and 39 more: https://git.openjdk.org/jdk/compare/8491fd5c1264d013420164824de87a091573469b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 3, 2022
@openjdk openjdk bot closed this Oct 3, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 3, 2022
@openjdk
Copy link

openjdk bot commented Oct 3, 2022

@sspitsyn Pushed as commit 07ed68e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sspitsyn sspitsyn deleted the br11 branch October 3, 2022 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
3 participants