8288302: Shenandoah: SIGSEGV in vm maybe related to jit compiling xerces

[rwestrel]

During igvn, at a heap stable test, a dominating heap stable test is
found that can be used to optimize out the current one. But this area
of the graph is actually dying and the current test has lost one of
its projection already, something the logic doesn't expect and which
causes the crash. The fix I propose is to simply detect that the heap
stable test is dying and skip the transformation.

/cc hotspot-compiler

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8288302: Shenandoah: SIGSEGV in vm maybe related to jit compiling xerces

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10491/head:pull/10491
$ git checkout pull/10491

Update a local copy of the PR:
$ git checkout pull/10491
$ git pull https://git.openjdk.org/jdk pull/10491/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10491

View PR using the GUI difftool:
$ git pr show -t 10491

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10491.diff

[bridgekeeper]

👋 Welcome back roland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rwestrel
The hotspot-compiler label was successfully added.

[mlbridge]

Webrevs

• 00: Full (afa40fd2)

[shipilev]

All right, looks reasonable.

[openjdk]

@rwestrel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288302: Shenandoah: SIGSEGV in vm maybe related to jit compiling xerces

Reviewed-by: shade, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 117 new commits pushed to the master branch:

• ae79af2: 8294740: Add cgroups keyword to TestDockerBasic.java
• 07ed68e: 8288907: serviceability/jvmti/vthread/SuspendResume1/SuspendResume1.java fails with -XX:TieredStopAtLevel=2,3
• 090cdfc: 8294726: Update URLs in minefield tests
• ed40d88: 8276849: Refresh the window icon on graphics configuration changes
• 081691a: 8294593: Check the size of the target on invocations of BigInteger::isProbablePrime
• a4f2078: 8294437: java/nio/channels/FileChannel tests slow on Windows
• c6e3daa: 8242115: C2 SATB barriers are not safepoint-safe
• e137f9f: 8293877: Rewrite MineField test
• 4f44fd6: 8237467: jlink plugin to save the argument files as input to jlink in the output image
• edfb18a: 8294695: Remove redundant deprecation suppression in ThreadGroup
• ... and 107 more: https://git.openjdk.org/jdk/compare/05c8cabdad7b5c573046b1c5d235c33ac5cb266c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TobiHartmann]

Looks good.

[rwestrel]

thanks @shipilev @TobiHartmann for the reviews.

[rwestrel]

/integrate

[openjdk]

Going to push as commit bf39b18.
Since your change was applied there have been 118 commits pushed to the master branch:

• f957ce9: 8294564: IGV: IllegalArgumentException for "Difference to current graph"
• ae79af2: 8294740: Add cgroups keyword to TestDockerBasic.java
• 07ed68e: 8288907: serviceability/jvmti/vthread/SuspendResume1/SuspendResume1.java fails with -XX:TieredStopAtLevel=2,3
• 090cdfc: 8294726: Update URLs in minefield tests
• ed40d88: 8276849: Refresh the window icon on graphics configuration changes
• 081691a: 8294593: Check the size of the target on invocations of BigInteger::isProbablePrime
• a4f2078: 8294437: java/nio/channels/FileChannel tests slow on Windows
• c6e3daa: 8242115: C2 SATB barriers are not safepoint-safe
• e137f9f: 8293877: Rewrite MineField test
• 4f44fd6: 8237467: jlink plugin to save the argument files as input to jlink in the output image
• ... and 108 more: https://git.openjdk.org/jdk/compare/05c8cabdad7b5c573046b1c5d235c33ac5cb266c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@rwestrel Pushed as commit bf39b18.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.