Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8294595: Add javax/swing/plaf/aqua/CustomComboBoxFocusTest.java to problem list #10495

Closed

Conversation

azvegint
Copy link
Member

@azvegint azvegint commented Sep 29, 2022

Problem listing PR


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8294595: Add javax/swing/plaf/aqua/CustomComboBoxFocusTest.java to problem list

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10495/head:pull/10495
$ git checkout pull/10495

Update a local copy of the PR:
$ git checkout pull/10495
$ git pull https://git.openjdk.org/jdk pull/10495/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10495

View PR using the GUI difftool:
$ git pr show -t 10495

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10495.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 29, 2022

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 29, 2022
@openjdk
Copy link

openjdk bot commented Sep 29, 2022

@azvegint To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@azvegint
Copy link
Member Author

/label client

@azvegint
Copy link
Member Author

/integrate auto

@openjdk
Copy link

openjdk bot commented Sep 29, 2022

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294595: Add javax/swing/plaf/aqua/CustomComboBoxFocusTest.java to problem list

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated client client-libs-dev@openjdk.org labels Sep 29, 2022
@openjdk
Copy link

openjdk bot commented Sep 29, 2022

@azvegint
The client label was successfully added.

@openjdk openjdk bot added the auto label Sep 29, 2022
@openjdk
Copy link

openjdk bot commented Sep 29, 2022

@azvegint This pull request will be automatically integrated when it is ready

@mlbridge
Copy link

mlbridge bot commented Sep 29, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 29, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Sep 29, 2022

Going to push as commit 29c70f1.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 29, 2022
@openjdk openjdk bot closed this Sep 29, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 29, 2022
@openjdk
Copy link

openjdk bot commented Sep 29, 2022

@openjdk[bot] Pushed as commit 29c70f1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto client client-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants