8294242: JFR: jfr print doesn't handle infinite duration well

[egahlin]

Hi,

Could I have review of a fix that improves the output of the jfr tool when there are event values that are infinite

Testing: jdk/jdk/jfr

Thanks
Erik

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires a CSR request to be approved

Issues

• JDK-8294242: JFR: jfr print doesn't handle infinite duration well
• JDK-8294518: Return ChronoUnit.FOREVER.getDuration() for unlimited timespans in JFR events (CSR)

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10497/head:pull/10497
$ git checkout pull/10497

Update a local copy of the PR:
$ git checkout pull/10497
$ git pull https://git.openjdk.org/jdk pull/10497/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10497

View PR using the GUI difftool:
$ git pr show -t 10497

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10497.diff

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (23255054)
• 00: Full (a761649d)

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294242: JFR: jfr print doesn't handle infinite duration well

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 64 new commits pushed to the master branch:

• 6e8f038: 8294567: IGV: IllegalStateException in search
• bc668b9: 8293099: JFR: Typo in TestRemoteDump.java
• 03f25a9: 8293562: blocked threads with KeepAliveCache.get
• a69ee85: 8292336: JFR: Warn users if -XX:StartFlightRecording:disk=false is specified with maxage or maxsize
• b8b9b97: 8294676: [JVMCI] InstalledCode.deoptimize(false) should not touch address field
• fd59430: 8294610: java/net/vthread/HttpALot.java is slow on Linux
• c7ab1ca: 8294609: C2: Improve inlining of methods with unloaded signature classes
• 375f02f: 8294608: Remove redundant unchecked suppression in FileDescriptor
• d207da8: 8294533: Documentation mistake in Process::getErrorStream and getInputStream
• da4e96d: 8276545: Fix handling of trap count overflow in Parse::Parse()
• ... and 54 more: https://git.openjdk.org/jdk/compare/a11477ce259d6d2a053117a2300ebb171145cfde...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[egahlin]

/integrate

[openjdk]

Going to push as commit 4d6668e.
Since your change was applied there have been 86 commits pushed to the master branch:

• 5a9cd33: 8294509: The sign extension bug applies to 'public static int[] convertSeedBytesToInts(byte[] seed, int n, int z)' in RandomSupport
• f03934e: 8294578: [PPC64] C2: Missing is_oop information when using disjoint compressed oops mode
• 3b476a1: 8292847: Zero: Allow ergonomics to select the GC
• 16047e8: 8292780: misc tests failed "assert(false) failed: graph should be schedulable"
• bf39b18: 8288302: Shenandoah: SIGSEGV in vm maybe related to jit compiling xerces
• f957ce9: 8294564: IGV: IllegalArgumentException for "Difference to current graph"
• ae79af2: 8294740: Add cgroups keyword to TestDockerBasic.java
• 07ed68e: 8288907: serviceability/jvmti/vthread/SuspendResume1/SuspendResume1.java fails with -XX:TieredStopAtLevel=2,3
• 090cdfc: 8294726: Update URLs in minefield tests
• ed40d88: 8276849: Refresh the window icon on graphics configuration changes
• ... and 76 more: https://git.openjdk.org/jdk/compare/a11477ce259d6d2a053117a2300ebb171145cfde...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit 4d6668e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.