New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8294307: ISO 4217 Amendment 173 Update #10499
Conversation
|
@justin-curtis-lu The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
@justin-curtis-lu This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 68 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@LanceAndersen, @bplb, @naotoj) but any other Committer may sponsor as well.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/integrate |
@justin-curtis-lu |
/sponsor |
Going to push as commit 3b1bc21.
Your commit was automatically rebased without conflicts. |
@naotoj @justin-curtis-lu Pushed as commit 3b1bc21. |
Problem: Amendment number outdated
Fix: Update amendment number + date in properties file and test case data file
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10499/head:pull/10499
$ git checkout pull/10499
Update a local copy of the PR:
$ git checkout pull/10499
$ git pull https://git.openjdk.org/jdk pull/10499/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10499
View PR using the GUI difftool:
$ git pr show -t 10499
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10499.diff