Skip to content

8252846: Fix ppc/s390 after "8231441: AArch64: Initial SVE backend su… #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

8252846: Fix ppc/s390 after "8231441: AArch64: Initial SVE backend su… #105

wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 10, 2020 •
edited by openjdk bot
Loading

…pport"

Hi,

this change fixes the issues after 8231441. The VM crashes right in the build after this change.
The fix is trivial.

Please review.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252846: Fix ppc/s390 after "8231441: AArch64: Initial SVE backend support" ⚠️ Title mismatch between PR and JBS.

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/105/head:pull/105
$ git checkout pull/105

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 10, 2020

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 10, 2020
@openjdk
Copy link

openjdk bot commented Sep 10, 2020

@GoeLin The following label will be automatically applied to this pull request: hotspot-compiler.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Sep 10, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 10, 2020

Webrevs

shipilev
shipilev approved these changes Sep 10, 2020
View reviewed changes
src/hotspot/share/opto/type.cpp
@@ -62,12 +62,14 @@ const Type::TypeInfo Type::_type_info[Type::lastype] = {
{ Bad, T_ARRAY, "array:", false, Node::NotAMachineReg, relocInfo::none }, // Array

#if defined(PPC64)
{ Bad, T_ILLEGAL, "vectora:", false, Op_VecA, relocInfo::none }, // VectorA.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think trailing "." in the comment is unnecessary. Please consider dropping before push.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Aleksey, I would not have put a dot there, but I just copied the line from the #else part which also has the dot.
So I'd rather leave it as-is.
Thanks for reviewing!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. No biggie, ship it.

src/hotspot/share/opto/type.cpp
{ Bad, T_ILLEGAL, "vectors:", false, 0, relocInfo::none }, // VectorS
{ Bad, T_ILLEGAL, "vectord:", false, Op_RegL, relocInfo::none }, // VectorD
{ Bad, T_ILLEGAL, "vectorx:", false, Op_VecX, relocInfo::none }, // VectorX
{ Bad, T_ILLEGAL, "vectory:", false, 0, relocInfo::none }, // VectorY
{ Bad, T_ILLEGAL, "vectorz:", false, 0, relocInfo::none }, // VectorZ
#elif defined(S390)
{ Bad, T_ILLEGAL, "vectora:", false, Op_VecA, relocInfo::none }, // VectorA.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think trailing "." in the comment is unnecessary. Please consider dropping before push.

@openjdk
Copy link

openjdk bot commented Sep 10, 2020 •
edited
Loading

@GoeLin This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8252846: Fix ppc/s390 after "8231441: AArch64: Initial SVE backend su…

Reviewed-by: shade
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • d236cf4: 8252995: Non-PCH builds broken by JDK-8250961

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate d236cf4becc917838a9dc4c0beff105c69905243.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 10, 2020
shipilev
shipilev approved these changes Sep 10, 2020
View reviewed changes
src/hotspot/share/opto/type.cpp
@@ -62,12 +62,14 @@ const Type::TypeInfo Type::_type_info[Type::lastype] = {
{ Bad, T_ARRAY, "array:", false, Node::NotAMachineReg, relocInfo::none }, // Array

#if defined(PPC64)
{ Bad, T_ILLEGAL, "vectora:", false, Op_VecA, relocInfo::none }, // VectorA.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. No biggie, ship it.

@GoeLin
Copy link
Member Author

GoeLin commented Sep 10, 2020

/integrate

@openjdk openjdk bot closed this Sep 10, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated labels Sep 10, 2020
@openjdk
Copy link

openjdk bot commented Sep 10, 2020

@GoeLin Since your change was applied there has been 1 commit pushed to the master branch:

  • d236cf4: 8252995: Non-PCH builds broken by JDK-8250961

Your commit was automatically rebased without conflicts.

Pushed as commit 7ccf435.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr Pull request is ready for review label Sep 10, 2020
@GoeLin GoeLin deleted the JDK-8252846-fix_ppc_s390 branch September 15, 2020 13:42
robehn pushed a commit to robehn/jdk that referenced this pull request Aug 15, 2023
@luhenry
Switch base image to rivos-sdk docker container (openjdk#105)
1146e55
pfirmstone pushed a commit to pfirmstone/jdk-with-authorization that referenced this pull request Nov 18, 2024
ProxyCodebaseSpi should have a means of adding a ClassLoader to the c…
0a783c1 
…ache when exporting services. openjdk#105
pfirmstone pushed a commit to pfirmstone/jdk-with-authorization that referenced this pull request Nov 18, 2024
ProxyCodebaseSpi should have a means of adding a ClassLoader to the c…
21ef387 
…ache when exporting services. openjdk#105
pfirmstone pushed a commit to pfirmstone/jdk-with-authorization that referenced this pull request Nov 18, 2024
ProxyCodebaseSpi should have a means of adding a ClassLoader to the c…
e0a039c 
…ache when exporting services. openjdk#105

Includes some other minor refactoring.
pfirmstone pushed a commit to pfirmstone/jdk-with-authorization that referenced this pull request Nov 18, 2024
ProxyCodebaseSpi should have a means of adding a ClassLoader to the c…
48e03f9 
…ache when exporting services. openjdk#105

Includes some other minor refactoring.
pfirmstone pushed a commit to pfirmstone/jdk-with-authorization that referenced this pull request Nov 18, 2024
ProxyCodebaseSpi should have a means of adding a ClassLoader to the c…
58b9aea 
…ache when exporting services. openjdk#105

Includes some other minor refactoring.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shipilev shipilev shipilev approved these changes

Assignees
No one assigned
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GoeLin @shipilev