Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8255847: Shenandoah: Shenandoah should not mark through weak roots #1050

Closed

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Nov 4, 2020

After moving weak root processing into concurrent phase, Shenandoah should no longer marks through weak roots, even when class unloading is disabled, given weak root processing no longer contributes to latency.

There are a couple of bugs:

  1. ShenandoahRootVerifier was not updated to reflect the change.
    The problem did not show up due to SH::parallel_cleaning() uses wrong flag to determine if it should cleanup weak roots, and it will be addressed in separate CR.

  2. Concurrent roots scanner should not mark through string dedup roots.

Test:

  • hotspot_gc_shenandoah
  • hotspot_gc_shenandoah with -XX:+ShenandoahVerify -XX:-ClassUnloading
  • hotspot_gc_shenandoah with -XX:+ShenandoahVerify -XX:+UseStringDeduplication

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Linux x86 Windows x64 macOS x64
Build ✔️ (5/5 passed) (2/2 failed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Failed test tasks

Issue

  • JDK-8255847: Shenandoah: Shenandoah should not mark through weak roots

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1050/head:pull/1050
$ git checkout pull/1050

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 4, 2020

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 4, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 4, 2020

@zhengyu123 The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc shenandoah labels Nov 4, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 4, 2020

Webrevs

rkennke
rkennke approved these changes Nov 4, 2020
Copy link
Contributor

@rkennke rkennke left a comment

Looks good. Make sure to merge latest tip to get full pre-submit testing in GitHub actions.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 4, 2020

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255847: Shenandoah: Shenandoah should not mark through weak roots

Reviewed-by: rkennke

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 4, 2020
@zhengyu123
Copy link
Contributor Author

@zhengyu123 zhengyu123 commented Nov 5, 2020

Looks good. Make sure to merge latest tip to get full pre-submit testing in GitHub actions.

Reran pre-submit tests, all clean.

@zhengyu123
Copy link
Contributor Author

@zhengyu123 zhengyu123 commented Nov 5, 2020

/integrate

@openjdk openjdk bot closed this Nov 5, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 5, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2020

@zhengyu123 Since your change was applied there have been 12 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 31918c5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@zhengyu123 zhengyu123 deleted the JDK-8255847-root-verifier branch Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated shenandoah
2 participants