Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8293099: JFR: Typo in TestRemoteDump.java #10509

Closed
wants to merge 1 commit into from

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented Sep 30, 2022

Could I have a review of this test fix.

Testing: jdk/jdk/jfr/jmx/TestRemoteDump.java

Thanks
Erik


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10509/head:pull/10509
$ git checkout pull/10509

Update a local copy of the PR:
$ git checkout pull/10509
$ git pull https://git.openjdk.org/jdk pull/10509/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10509

View PR using the GUI difftool:
$ git pr show -t 10509

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10509.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 30, 2022

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 30, 2022

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Sep 30, 2022
@egahlin egahlin marked this pull request as ready for review September 30, 2022 12:23
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 30, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 30, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 30, 2022

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293099: JFR: Typo in TestRemoteDump.java

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • f015733: 8294357: (tz) Update Timezone Data to 2022d
  • 64da862: 8287597: List all preview features on the javadoc PREVIEW page
  • b4e1e41: 8293000: Review running times of jshell regression tests
  • 6d83482: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts
  • 6974978: 8294521: Parallel: Remove unused field in UpdateDensePrefixAndCompactionTask
  • 81fda1b: 8294569: Remove CardTable::_last_valid_index
  • 7c60e6d: 8293770: RISC-V: Reuse runtime call trampolines
  • 9dce865: 8294115: JNI local refs exceeds capacity warning in NetworkInterface::getAll
  • b030c7d: 8225235: Unused field defaultIndex in NetworkInterface

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 30, 2022
@egahlin
Copy link
Member Author

egahlin commented Oct 3, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 3, 2022

Going to push as commit bc668b9.
Since your change was applied there have been 24 commits pushed to the master branch:

  • 03f25a9: 8293562: blocked threads with KeepAliveCache.get
  • a69ee85: 8292336: JFR: Warn users if -XX:StartFlightRecording:disk=false is specified with maxage or maxsize
  • b8b9b97: 8294676: [JVMCI] InstalledCode.deoptimize(false) should not touch address field
  • fd59430: 8294610: java/net/vthread/HttpALot.java is slow on Linux
  • c7ab1ca: 8294609: C2: Improve inlining of methods with unloaded signature classes
  • 375f02f: 8294608: Remove redundant unchecked suppression in FileDescriptor
  • d207da8: 8294533: Documentation mistake in Process::getErrorStream and getInputStream
  • da4e96d: 8276545: Fix handling of trap count overflow in Parse::Parse()
  • 48674d4: 8291428: JFR: 'jfr print' displays incorrect timestamps during DST
  • 3b1bc21: 8294307: ISO 4217 Amendment 173 Update
  • ... and 14 more: https://git.openjdk.org/jdk/compare/a07975bf3e321bdf02748693930c2523fa1df22d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 3, 2022
@openjdk openjdk bot closed this Oct 3, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 3, 2022
@openjdk
Copy link

openjdk bot commented Oct 3, 2022

@egahlin Pushed as commit bc668b9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
2 participants