Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8294679: RISC-V: Misc crash dump improvements #10512

Closed
wants to merge 1 commit into from

Conversation

RealFYang
Copy link
Member

@RealFYang RealFYang commented Sep 30, 2022

Issue https://bugs.openjdk.org/browse/JDK-8294160 only handles x86 & aarch64.
This adds handling for this case on RISC-V: When calling a bad address, we usually don't get a meaningful stack backtrace, but in many situations we can if we know where to find the caller information.

Testing: Tier1 tested on HiFive Unmatched board.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10512/head:pull/10512
$ git checkout pull/10512

Update a local copy of the PR:
$ git checkout pull/10512
$ git pull https://git.openjdk.org/jdk pull/10512/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10512

View PR using the GUI difftool:
$ git pr show -t 10512

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10512.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 30, 2022

👋 Welcome back fyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 30, 2022
@openjdk
Copy link

openjdk bot commented Sep 30, 2022

@RealFYang The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Sep 30, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 30, 2022

Webrevs

Copy link
Member

@feilongjiang feilongjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Oct 4, 2022

@RealFYang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294679: RISC-V: Misc crash dump improvements

Reviewed-by: fjiang, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

  • 3b476a1: 8292847: Zero: Allow ergonomics to select the GC
  • 16047e8: 8292780: misc tests failed "assert(false) failed: graph should be schedulable"
  • bf39b18: 8288302: Shenandoah: SIGSEGV in vm maybe related to jit compiling xerces
  • f957ce9: 8294564: IGV: IllegalArgumentException for "Difference to current graph"
  • ae79af2: 8294740: Add cgroups keyword to TestDockerBasic.java
  • 07ed68e: 8288907: serviceability/jvmti/vthread/SuspendResume1/SuspendResume1.java fails with -XX:TieredStopAtLevel=2,3
  • 090cdfc: 8294726: Update URLs in minefield tests
  • ed40d88: 8276849: Refresh the window icon on graphics configuration changes
  • 081691a: 8294593: Check the size of the target on invocations of BigInteger::isProbablePrime
  • a4f2078: 8294437: java/nio/channels/FileChannel tests slow on Windows
  • ... and 26 more: https://git.openjdk.org/jdk/compare/c2ce43cbb07284419f6d511a2ac78fa53aca095e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 4, 2022
@RealFYang
Copy link
Member Author

RealFYang commented Oct 6, 2022

@feilongjiang @shipilev : Thanks for the review. Tier2-3 test is also clean.
/integrate

@openjdk
Copy link

openjdk bot commented Oct 6, 2022

Going to push as commit 8f56115.
Since your change was applied there have been 67 commits pushed to the master branch:

  • e986a97: 8292330: Update JCov version to 3.0.13
  • d4142d8: 8290036: Define and specify Runtime shutdown sequence
  • 0ec1838: 8294869: Correct failure of RemovedJDKInternals.java after JDK-8294618
  • 87acfee: 8294397: Replace StringBuffer with StringBuilder within java.text
  • f2c5718: 8294734: Redundant override in AES implementation
  • 536c9a5: 8294618: Update openjdk.java.net => openjdk.org
  • f531dae: 8294840: langtools OptionalDependencyTest.java use File.pathSeparator
  • ee6c391: 8289925: Shared code shouldn't reference the platform specific method frame::interpreter_frame_last_sp()
  • bd90c4c: 8282900: runtime/stringtable/StringTableCleaningTest.java verify unavailable at this moment
  • 979efd4: 8289004: investigate if SharedRuntime::get_java_tid parameter should be a JavaThread*
  • ... and 57 more: https://git.openjdk.org/jdk/compare/c2ce43cbb07284419f6d511a2ac78fa53aca095e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 6, 2022
@openjdk openjdk bot closed this Oct 6, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 6, 2022
@openjdk
Copy link

openjdk bot commented Oct 6, 2022

@RealFYang Pushed as commit 8f56115.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealFYang RealFYang deleted the JDK-8294679 branch October 17, 2022 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants