-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8294679: RISC-V: Misc crash dump improvements #10512
Conversation
👋 Welcome back fyang! A progress list of the required criteria for merging this PR into |
@RealFYang The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@RealFYang This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 36 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@feilongjiang @shipilev : Thanks for the review. Tier2-3 test is also clean. |
Going to push as commit 8f56115.
Your commit was automatically rebased without conflicts. |
@RealFYang Pushed as commit 8f56115. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Issue https://bugs.openjdk.org/browse/JDK-8294160 only handles x86 & aarch64.
This adds handling for this case on RISC-V: When calling a bad address, we usually don't get a meaningful stack backtrace, but in many situations we can if we know where to find the caller information.
Testing: Tier1 tested on HiFive Unmatched board.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10512/head:pull/10512
$ git checkout pull/10512
Update a local copy of the PR:
$ git checkout pull/10512
$ git pull https://git.openjdk.org/jdk pull/10512/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10512
View PR using the GUI difftool:
$ git pr show -t 10512
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10512.diff