Skip to content

Conversation

@turbanoff
Copy link
Member

@turbanoff turbanoff commented Oct 1, 2022

This suppression were added with Loom integration, but method Thread.getThreadGroup() is not deprecated.
Let's cleanup code a bit.
https://mail.openjdk.org/pipermail/core-libs-dev/2022-September/094907.html


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8294695: Remove redundant deprecation suppression in ThreadGroup

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10521/head:pull/10521
$ git checkout pull/10521

Update a local copy of the PR:
$ git checkout pull/10521
$ git pull https://git.openjdk.org/jdk pull/10521/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10521

View PR using the GUI difftool:
$ git pr show -t 10521

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10521.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 1, 2022

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@turbanoff turbanoff changed the title [PATCH] Remove redundant deprecation suppression in ThreadGroup 8294695: Remove redundant deprecation suppression in ThreadGroup Oct 1, 2022
@openjdk
Copy link

openjdk bot commented Oct 1, 2022

@turbanoff The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org rfr Pull request is ready for review labels Oct 1, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 1, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 1, 2022

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294695: Remove redundant deprecation suppression in ThreadGroup

Reviewed-by: alanb, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • a69ee85: 8292336: JFR: Warn users if -XX:StartFlightRecording:disk=false is specified with maxage or maxsize

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 1, 2022
@turbanoff
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 3, 2022

Going to push as commit edfb18a.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 46633e6: 8294698: Remove unused 'checkedExceptions' param from MethodAccessorGenerator.generateMethod()
  • f2a32d9: 8293691: converting a defined BasicType value to a string should not crash the VM
  • ccc1d31: 8294529: IGV: Highlight the current graphs in the Outline
  • 08a7ecf: 8294671: Remove unused CardValues::last_card
  • 5fe837a: 8294236: [IR Framework] CPU preconditions are overriden by regular preconditions
  • 8e9cfeb: 8294431: jshell reports error on initialisation of static final field of anonymous class
  • 6e8f038: 8294567: IGV: IllegalStateException in search
  • bc668b9: 8293099: JFR: Typo in TestRemoteDump.java
  • 03f25a9: 8293562: blocked threads with KeepAliveCache.get
  • a69ee85: 8292336: JFR: Warn users if -XX:StartFlightRecording:disk=false is specified with maxage or maxsize

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 3, 2022
@openjdk openjdk bot closed this Oct 3, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 3, 2022
@openjdk
Copy link

openjdk bot commented Oct 3, 2022

@turbanoff Pushed as commit edfb18a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@turbanoff turbanoff deleted the redundant_deprecated_suppression_ThreadGroup branch October 27, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants