Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295026: Remove unused fields in StyleSheet #10523

Conversation

turbanoff
Copy link
Member

@turbanoff turbanoff commented Oct 1, 2022

There are 3 unused fields in single StyleSheet file:

  1. static final Border noBorder = new EmptyBorder(0,0,0,0);
  2. static final int DEFAULT_FONT_SIZE = 3;
  3. URL imageurl; in nested javax.swing.text.html.StyleSheet.ListPainter class

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10523/head:pull/10523
$ git checkout pull/10523

Update a local copy of the PR:
$ git checkout pull/10523
$ git pull https://git.openjdk.org/jdk pull/10523/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10523

View PR using the GUI difftool:
$ git pr show -t 10523

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10523.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 1, 2022

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 1, 2022

@turbanoff The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Oct 1, 2022
Copy link
Contributor

@SWinxy SWinxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice little spring fall cleaning :)

@turbanoff turbanoff changed the title [PATCH] Remove unused fields in StyleSheet 8295026: Remove unused fields in StyleSheet Oct 9, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 9, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 9, 2022

Webrevs

Copy link
Member

@aivanov-jdk aivanov-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk
Copy link

openjdk bot commented Oct 10, 2022

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295026: Remove unused fields in StyleSheet

Reviewed-by: aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 152 new commits pushed to the master branch:

  • 7e4868d: 8294847: Fix calculation of G1 effective scanned cards prediction
  • 2f60675: 8294997: Improve ECC math operations
  • 94caecb: 8294906: Memory leak in PKCS11 NSS TLS server
  • 03e63a2: 8295225: [JVMCI] codeStart should be cleared when entryPoint is cleared
  • 26ac836: 8291638: Keep-Alive timeout of 0 should close connection immediately
  • 6ae7e4d: 8293984: Unnecessary Vector usage in PropertyEditorSupport
  • cd1357b: 8295229: Try to verify gtest version
  • 90fb9a0: 8295102: Always load @lambda-form-invoker lines from default classlist
  • ac19414: 8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance
  • 1961e81: 8289509: Improve test coverage for XPath Axes: descendant, descendant-or-self, following, following-sibling
  • ... and 142 more: https://git.openjdk.org/jdk/compare/b8b9b97a1a3e07777da2e39ac4779ef7b77434c7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 10, 2022
@turbanoff
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 14, 2022

Going to push as commit be3b335.
Since your change was applied there have been 162 commits pushed to the master branch:

  • 67046ae: 8276687: Remove support for JDK 1.4.1 PerfData shared memory files
  • b30d922: 8292876: Do not include the deprecated userinfo component of the URI in HTTP/2 headers
  • 2b4830a: 8295017: Remove Windows specific workaround in JLI_Snprintf
  • fdb74ed: 8295301: Problem list TrayIcon tests that fail on Ubuntu 22.04
  • 21407de: 8295173: (tz) Update Timezone Data to 2022e
  • f5f8df1: 8295295: CDS ArchivedEnumTest fails with StaticProperty::JAVA_LOCALE_USE_OLD_ISO_CODES
  • 18dd9ee: 8295025: (bf) ByteBuffer "Access to binary data" section suggests putFloat is void
  • 4224d45: 8295232: "java.locale.useOldISOCodes" property is read lazily
  • 3b34387: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB
  • c7f6543: 8295223: JFR: At most one native periodic event thread at a time
  • ... and 152 more: https://git.openjdk.org/jdk/compare/b8b9b97a1a3e07777da2e39ac4779ef7b77434c7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 14, 2022
@openjdk openjdk bot closed this Oct 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 14, 2022
@openjdk
Copy link

openjdk bot commented Oct 14, 2022

@turbanoff Pushed as commit be3b335.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@turbanoff turbanoff deleted the unused_noBorder_field_in_StyleSheet branch October 27, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants