Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8294702 - BufferedInputStream uses undefined value range for markpos #10528

Closed
wants to merge 2 commits into from

Conversation

mkarg
Copy link
Contributor

@mkarg mkarg commented Oct 3, 2022

Fixes JDK-8294702


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8294702: BufferedInputStream uses undefined value range for markpos

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10528/head:pull/10528
$ git checkout pull/10528

Update a local copy of the PR:
$ git checkout pull/10528
$ git pull https://git.openjdk.org/jdk pull/10528/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10528

View PR using the GUI difftool:
$ git pr show -t 10528

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10528.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 3, 2022

👋 Welcome back mkarg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 3, 2022
@openjdk
Copy link

openjdk bot commented Oct 3, 2022

@mkarg The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Oct 3, 2022
@mkarg
Copy link
Contributor Author

mkarg commented Oct 3, 2022

@AlanBateman Kindly requesting review, as originally it was you who complained about using < 0 in that class, see #10525 (comment).

@mlbridge
Copy link

mlbridge bot commented Oct 3, 2022

Webrevs

Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, just change the description to "BufferedInputStream uses undefined ..." as this issue is nothing to do with transferTo.

Copy link

@Sarawin9 Sarawin9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Sarawin9, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user Sarawin9 for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

@mkarg mkarg changed the title JDK-8294702 - BufferedInputStream.transferTo uses undefined value range for markpos JDK-8294702 - BufferedInputStream uses undefined value range for markpos Oct 3, 2022
@mkarg
Copy link
Contributor Author

mkarg commented Oct 3, 2022

This looks fine, just change the description to "BufferedInputStream uses undefined ..." as this issue is nothing to do with transferTo.

Done. Thanks! :-)

@openjdk
Copy link

openjdk bot commented Oct 3, 2022

⚠️ @mkarg the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout JDK-8294702
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented Oct 3, 2022

@mkarg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294702: BufferedInputStream uses undefined value range for markpos

Reviewed-by: alanb, bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 110 new commits pushed to the master branch:

  • 9d0009e: 6777156: GTK L&F: JFileChooser can jump beyond root directory in combobox and selection textarea.
  • 3ebe5ad: 8294751: Zero: Allow larger default heaps
  • 33d0618: 6616245: NullPointerException when using JFileChooser with a custom FileView
  • fba763f: 8291519: jdk/jfr/api/event/TestShouldCommit.java failed with Unexpected value of shouldCommit()
  • 6053bf0: 8293782: Shenandoah: some tests failed on lock rank check
  • 4435d56: 8282395: URL.openConnection can throw IOOBE
  • fe70487: 8294958: java/net/httpclient/ConnectTimeout tests are slow
  • 97f1321: 8294356: IGV: scheduled graphs contain duplicated elements
  • 5e05e42: 8294901: remove pre-VS2017 checks in Windows related coding
  • e775acf: 8293986: Incorrect double-checked locking in com.sun.beans.introspect.ClassInfo
  • ... and 100 more: https://git.openjdk.org/jdk/compare/03f25a9c6924430ec4063b801b2b6ca55b9067c9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman, @bplb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated sponsor Pull request is ready to be sponsored labels Oct 3, 2022
@openjdk
Copy link

openjdk bot commented Oct 3, 2022

@mkarg
Your change (at version 9b8310a) is now ready to be sponsored by a Committer.

@mkarg
Copy link
Contributor Author

mkarg commented Oct 3, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 3, 2022

@mkarg
Your change (at version 9b8310a) is now ready to be sponsored by a Committer.

@mkarg
Copy link
Contributor Author

mkarg commented Oct 3, 2022

@AlanBateman Kindly requesting /sponsor: -)

@openjdk openjdk bot removed the sponsor Pull request is ready to be sponsored label Oct 9, 2022
@bplb
Copy link
Member

bplb commented Oct 11, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 11, 2022

@bplb The PR has been updated since the change author (@mkarg) issued the integrate command - the author must perform this command again.

@mkarg
Copy link
Contributor Author

mkarg commented Oct 11, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 11, 2022
@openjdk
Copy link

openjdk bot commented Oct 11, 2022

@mkarg
Your change (at version 8fefccf) is now ready to be sponsored by a Committer.

@mkarg
Copy link
Contributor Author

mkarg commented Oct 11, 2022

@bplb Kindly requesting to repeat /sponsor. :-)

@bplb
Copy link
Member

bplb commented Oct 11, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 11, 2022

Going to push as commit 619cd82.
Since your change was applied there have been 110 commits pushed to the master branch:

  • 9d0009e: 6777156: GTK L&F: JFileChooser can jump beyond root directory in combobox and selection textarea.
  • 3ebe5ad: 8294751: Zero: Allow larger default heaps
  • 33d0618: 6616245: NullPointerException when using JFileChooser with a custom FileView
  • fba763f: 8291519: jdk/jfr/api/event/TestShouldCommit.java failed with Unexpected value of shouldCommit()
  • 6053bf0: 8293782: Shenandoah: some tests failed on lock rank check
  • 4435d56: 8282395: URL.openConnection can throw IOOBE
  • fe70487: 8294958: java/net/httpclient/ConnectTimeout tests are slow
  • 97f1321: 8294356: IGV: scheduled graphs contain duplicated elements
  • 5e05e42: 8294901: remove pre-VS2017 checks in Windows related coding
  • e775acf: 8293986: Incorrect double-checked locking in com.sun.beans.introspect.ClassInfo
  • ... and 100 more: https://git.openjdk.org/jdk/compare/03f25a9c6924430ec4063b801b2b6ca55b9067c9...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 11, 2022
@openjdk openjdk bot closed this Oct 11, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 11, 2022
@openjdk
Copy link

openjdk bot commented Oct 11, 2022

@bplb @mkarg Pushed as commit 619cd82.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
4 participants