Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8294705: Disable an assertion in test/jdk/java/util/DoubleStreamSums/CompensatedSums.java #10529

Closed
wants to merge 2 commits into from
Closed

8294705: Disable an assertion in test/jdk/java/util/DoubleStreamSums/CompensatedSums.java #10529

wants to merge 2 commits into from

Conversation

rgiulietti
Copy link
Contributor

@rgiulietti rgiulietti commented Oct 3, 2022 •
edited by openjdk bot
Loading

Disables a specific assertion that causes intermittent failures.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8294705: Disable an assertion in test/jdk/java/util/DoubleStreamSums/CompensatedSums.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10529/head:pull/10529
$ git checkout pull/10529

Update a local copy of the PR:
$ git checkout pull/10529
$ git pull https://git.openjdk.org/jdk pull/10529/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10529

View PR using the GUI difftool:
$ git pr show -t 10529

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10529.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 3, 2022

👋 Welcome back rgiulietti! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 3, 2022
@openjdk
Copy link

openjdk bot commented Oct 3, 2022

@rgiulietti The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Oct 3, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 3, 2022 •
edited
Loading

Webrevs

bplb
bplb reviewed Oct 20, 2022
View reviewed changes
test/jdk/java/util/DoubleStreamSums/CompensatedSums.java Outdated
@@ -91,7 +91,7 @@ public void testCompensatedSums() {
}

Assert.assertTrue(jdkParallelStreamError <= goodParallelStreamError);
Assert.assertTrue(badParallelStreamError >= jdkParallelStreamError);
// Assert.assertTrue(badParallelStreamError >= jdkParallelStreamError);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a comment here, something like in the issue description?

// Due to floating-point addition being inherently non-associative, and due to the unpredictable scheduling of the threads used in parallel streams, this assertion can fail intermittently hence is suppressed for now.

bplb
bplb approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@bplb bplb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved whether or not any comment is added.

@openjdk
Copy link

openjdk bot commented Oct 20, 2022 •
edited
Loading

@rgiulietti This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294705: Disable an assertion in test/jdk/java/util/DoubleStreamSums/CompensatedSums.java

Reviewed-by: bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 288 new commits pushed to the master branch:

  • 9d0cfd1: 8294948: Document IllegalArgumentException and NullPointerException thrown by URLStreamHandler::parseURL and URLStreamHandler::setURL
  • dcd4650: 8294916: Cancelling a request must eventually cause its response body subscriber to be unregistered
  • 4f994c0: 8295709: Linux AArch64 builds broken after JDK-8294438
  • 545021b: 8294438: Fix misleading-indentation warnings in hotspot
  • c5e0464: 8291456: com/sun/jdi/ClassUnloadEventTest.java failed with: Wrong number of class unload events: expected 10 got 4
  • 8d4c077: 8295302: Do not use ArrayList when LambdaForm has a single ClassData
  • 017e798: 8293939: Move continuation_enter_setup and friends
  • f872467: 8255746: Make PrintCompilation available on a per method level
  • 388a56e: 8294467: Fix sequence-point warnings in Hotspot
  • ceb5b08: 8294468: Fix char-subscripts warnings in Hotspot
  • ... and 278 more: https://git.openjdk.org/jdk/compare/ce85cac947158b4e1f554c55f726c923a49b1a41...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 20, 2022
@rgiulietti
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 20, 2022

Going to push as commit c08ff2c.
Since your change was applied there have been 289 commits pushed to the master branch:

  • d5a1521: 8295470: Update openjdk.java.net => openjdk.org URLs in test code
  • 9d0cfd1: 8294948: Document IllegalArgumentException and NullPointerException thrown by URLStreamHandler::parseURL and URLStreamHandler::setURL
  • dcd4650: 8294916: Cancelling a request must eventually cause its response body subscriber to be unregistered
  • 4f994c0: 8295709: Linux AArch64 builds broken after JDK-8294438
  • 545021b: 8294438: Fix misleading-indentation warnings in hotspot
  • c5e0464: 8291456: com/sun/jdi/ClassUnloadEventTest.java failed with: Wrong number of class unload events: expected 10 got 4
  • 8d4c077: 8295302: Do not use ArrayList when LambdaForm has a single ClassData
  • 017e798: 8293939: Move continuation_enter_setup and friends
  • f872467: 8255746: Make PrintCompilation available on a per method level
  • 388a56e: 8294467: Fix sequence-point warnings in Hotspot
  • ... and 279 more: https://git.openjdk.org/jdk/compare/ce85cac947158b4e1f554c55f726c923a49b1a41...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 20, 2022
@openjdk openjdk bot closed this Oct 20, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 20, 2022
@openjdk
Copy link

openjdk bot commented Oct 20, 2022

@rgiulietti Pushed as commit c08ff2c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@rgiulietti rgiulietti deleted the JDK-8294705 branch October 20, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bplb bplb bplb approved these changes

Assignees
No one assigned
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgiulietti @bplb