8294509: The sign extension bug applies to 'public static int[] convertSeedBytesToInts(byte[] seed, int n, int z)' in RandomSupport

[rgiulietti]

Fixes sign extension propagation to higher bits.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8294509: The sign extension bug applies to 'public static int[] convertSeedBytesToInts(byte[] seed, int n, int z)' in RandomSupport

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10530/head:pull/10530
$ git checkout pull/10530

Update a local copy of the PR:
$ git checkout pull/10530
$ git pull https://git.openjdk.org/jdk pull/10530/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10530

View PR using the GUI difftool:
$ git pr show -t 10530

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10530.diff

[bridgekeeper]

👋 Welcome back rgiulietti! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rgiulietti The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b3c3770c)

[shipilev]

This looks good! Remarkably, SonarCloud reports the bug on this line ("Prevent "int" promotion by adding '& 0xff' to this expression"), but I skipped it when generating the reports, d'uh.

[openjdk]

@rgiulietti This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294509: The sign extension bug applies to 'public static int[] convertSeedBytesToInts(byte[] seed, int n, int z)' in RandomSupport

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 53 new commits pushed to the master branch:

• 3b476a1: 8292847: Zero: Allow ergonomics to select the GC
• 16047e8: 8292780: misc tests failed "assert(false) failed: graph should be schedulable"
• bf39b18: 8288302: Shenandoah: SIGSEGV in vm maybe related to jit compiling xerces
• f957ce9: 8294564: IGV: IllegalArgumentException for "Difference to current graph"
• ae79af2: 8294740: Add cgroups keyword to TestDockerBasic.java
• 07ed68e: 8288907: serviceability/jvmti/vthread/SuspendResume1/SuspendResume1.java fails with -XX:TieredStopAtLevel=2,3
• 090cdfc: 8294726: Update URLs in minefield tests
• ed40d88: 8276849: Refresh the window icon on graphics configuration changes
• 081691a: 8294593: Check the size of the target on invocations of BigInteger::isProbablePrime
• a4f2078: 8294437: java/nio/channels/FileChannel tests slow on Windows
• ... and 43 more: https://git.openjdk.org/jdk/compare/ce85cac947158b4e1f554c55f726c923a49b1a41...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[rgiulietti]

/integrate

[openjdk]

Going to push as commit 5a9cd33.
Since your change was applied there have been 54 commits pushed to the master branch:

• f03934e: 8294578: [PPC64] C2: Missing is_oop information when using disjoint compressed oops mode
• 3b476a1: 8292847: Zero: Allow ergonomics to select the GC
• 16047e8: 8292780: misc tests failed "assert(false) failed: graph should be schedulable"
• bf39b18: 8288302: Shenandoah: SIGSEGV in vm maybe related to jit compiling xerces
• f957ce9: 8294564: IGV: IllegalArgumentException for "Difference to current graph"
• ae79af2: 8294740: Add cgroups keyword to TestDockerBasic.java
• 07ed68e: 8288907: serviceability/jvmti/vthread/SuspendResume1/SuspendResume1.java fails with -XX:TieredStopAtLevel=2,3
• 090cdfc: 8294726: Update URLs in minefield tests
• ed40d88: 8276849: Refresh the window icon on graphics configuration changes
• 081691a: 8294593: Check the size of the target on invocations of BigInteger::isProbablePrime
• ... and 44 more: https://git.openjdk.org/jdk/compare/ce85cac947158b4e1f554c55f726c923a49b1a41...master

Your commit was automatically rebased without conflicts.

[openjdk]

@rgiulietti Pushed as commit 5a9cd33.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.