Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8289004: investigate if SharedRuntime::get_java_tid parameter should be a JavaThread* #10532

Closed
wants to merge 2 commits into from

Conversation

robehn
Copy link
Contributor

@robehn robehn commented Oct 3, 2022

Hi, please consider.

Yes it should be JavaThread*.
But some additional places needed to use JavaThread*

Passes t1-3.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8289004: investigate if SharedRuntime::get_java_tid parameter should be a JavaThread*

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10532/head:pull/10532
$ git checkout pull/10532

Update a local copy of the PR:
$ git checkout pull/10532
$ git pull https://git.openjdk.org/jdk pull/10532/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10532

View PR using the GUI difftool:
$ git pr show -t 10532

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10532.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 3, 2022

👋 Welcome back rehn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 3, 2022
@openjdk
Copy link

openjdk bot commented Oct 3, 2022

@robehn The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Oct 3, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 3, 2022

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine, but some additional changes needed in get_java_tid.

Thanks.

src/hotspot/share/runtime/sharedRuntime.cpp Outdated Show resolved Hide resolved
src/hotspot/share/runtime/sharedRuntime.cpp Outdated Show resolved Hide resolved
@openjdk
Copy link

openjdk bot commented Oct 4, 2022

@robehn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289004: investigate if SharedRuntime::get_java_tid parameter should be a JavaThread*

Reviewed-by: dholmes, jsjolen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 41 new commits pushed to the master branch:

  • 4bdd1c9: 8290964: C2 compilation fails with assert "non-reduction loop contains reduction nodes"
  • b4e74ae: 8294514: Wrong initialization of nmethod::_consts_offset for native nmethods
  • 953ce8d: 8293701: jdeps InverseDepsAnalyzer runs into NoSuchElementException: No value present
  • be82cff: 8294748: Cleanup unneeded references to hg
  • 43dbf58: 8186765: Speed up test sun/net/www/protocol/https/HttpsClient/ProxyAuthTest.java
  • 755958e: 8294376: Minimize disabled warnings in java.base
  • 1dafbe3: 8294539: Augment discussion of equivalence relations on floating-point values
  • b2e86a6: 8294255: Add link to DEFAULT_WAIT_TIME in javadoc for SunToolKit.realsSync
  • b22a38d: 8292309: Fix java/awt/PrintJob/ConstrainedPrintingTest/ConstrainedPrintingTest.java test
  • 121d4a5: 8293579: tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java fails on Japanese Windows platform
  • ... and 31 more: https://git.openjdk.org/jdk/compare/a69ee85308ae2fd5d9fd5aed69b16ca70119976a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 4, 2022
@robehn
Copy link
Contributor Author

robehn commented Oct 5, 2022

Thanks David!

Copy link
Contributor

@jdksjolen jdksjolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks for the fix.

@robehn
Copy link
Contributor Author

robehn commented Oct 5, 2022

Thanks!

@robehn
Copy link
Contributor Author

robehn commented Oct 5, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 5, 2022

Going to push as commit 979efd4.
Since your change was applied there have been 44 commits pushed to the master branch:

  • b9eeec2: 8294310: compare.sh fails on macos after JDK-8293550
  • 13a5000: 8294151: JFR: Unclear exception message when dumping stopped in memory recording
  • 8ebebbc: 8294368: Java incremental builds broken on Windows after JDK-8293116
  • 4bdd1c9: 8290964: C2 compilation fails with assert "non-reduction loop contains reduction nodes"
  • b4e74ae: 8294514: Wrong initialization of nmethod::_consts_offset for native nmethods
  • 953ce8d: 8293701: jdeps InverseDepsAnalyzer runs into NoSuchElementException: No value present
  • be82cff: 8294748: Cleanup unneeded references to hg
  • 43dbf58: 8186765: Speed up test sun/net/www/protocol/https/HttpsClient/ProxyAuthTest.java
  • 755958e: 8294376: Minimize disabled warnings in java.base
  • 1dafbe3: 8294539: Augment discussion of equivalence relations on floating-point values
  • ... and 34 more: https://git.openjdk.org/jdk/compare/a69ee85308ae2fd5d9fd5aed69b16ca70119976a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 5, 2022
@openjdk openjdk bot closed this Oct 5, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 5, 2022
@openjdk
Copy link

openjdk bot commented Oct 5, 2022

@robehn Pushed as commit 979efd4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@robehn robehn deleted the 8289004 branch December 6, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
3 participants