8294593: Check the size of the target on invocations of BigInteger::isProbablePrime

[rgiulietti]

Throws an ArithemticException when the target is huge.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8294593: Check the size of the target on invocations of BigInteger::isProbablePrime

Reviewers

• Joe Darcy (@jddarcy - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10541/head:pull/10541
$ git checkout pull/10541

Update a local copy of the PR:
$ git checkout pull/10541
$ git pull https://git.openjdk.org/jdk pull/10541/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10541

View PR using the GUI difftool:
$ git pr show -t 10541

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10541.diff

[bridgekeeper]

👋 Welcome back rgiulietti! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[rgiulietti]

This parallels the existing behavior in BigInteger::nextProbablePrime.

A separate CSR + PR will follow.

[openjdk]

@rgiulietti The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (cf026cf7)

[openjdk]

@rgiulietti This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294593: Check the size of the target on invocations of BigInteger::isProbablePrime

Reviewed-by: darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

• e137f9f: 8293877: Rewrite MineField test
• 4f44fd6: 8237467: jlink plugin to save the argument files as input to jlink in the output image
• edfb18a: 8294695: Remove redundant deprecation suppression in ThreadGroup
• 46633e6: 8294698: Remove unused 'checkedExceptions' param from MethodAccessorGenerator.generateMethod()
• f2a32d9: 8293691: converting a defined BasicType value to a string should not crash the VM
• ccc1d31: 8294529: IGV: Highlight the current graphs in the Outline
• 08a7ecf: 8294671: Remove unused CardValues::last_card
• 5fe837a: 8294236: [IR Framework] CPU preconditions are overriden by regular preconditions
• 8e9cfeb: 8294431: jshell reports error on initialisation of static final field of anonymous class
• 6e8f038: 8294567: IGV: IllegalStateException in search
• ... and 32 more: https://git.openjdk.org/jdk/compare/ce85cac947158b4e1f554c55f726c923a49b1a41...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[rgiulietti]

/integrate

[openjdk]

Going to push as commit 081691a.
Since your change was applied there have been 44 commits pushed to the master branch:

• a4f2078: 8294437: java/nio/channels/FileChannel tests slow on Windows
• c6e3daa: 8242115: C2 SATB barriers are not safepoint-safe
• e137f9f: 8293877: Rewrite MineField test
• 4f44fd6: 8237467: jlink plugin to save the argument files as input to jlink in the output image
• edfb18a: 8294695: Remove redundant deprecation suppression in ThreadGroup
• 46633e6: 8294698: Remove unused 'checkedExceptions' param from MethodAccessorGenerator.generateMethod()
• f2a32d9: 8293691: converting a defined BasicType value to a string should not crash the VM
• ccc1d31: 8294529: IGV: Highlight the current graphs in the Outline
• 08a7ecf: 8294671: Remove unused CardValues::last_card
• 5fe837a: 8294236: [IR Framework] CPU preconditions are overriden by regular preconditions
• ... and 34 more: https://git.openjdk.org/jdk/compare/ce85cac947158b4e1f554c55f726c923a49b1a41...master

Your commit was automatically rebased without conflicts.

[openjdk]

@rgiulietti Pushed as commit 081691a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.