8291429: java/lang/Thread/virtual/ThreadAPI.java timed out on single core system

[AlanBateman]

This is a test only change for two tests for virtual threads that hang/timeout on single core systems. The two tests involve pinning and require at least two carrier threads. The test lib used by these tests is updated to define a new method that ensures parallelism is at least a given value and both tests are updated to use this. There are a number of tests in the debugger area that may potentially use this in the future.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8291429: java/lang/Thread/virtual/ThreadAPI.java timed out on single core system

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer)
• Chris Plummer (@plummercj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10562/head:pull/10562
$ git checkout pull/10562

Update a local copy of the PR:
$ git checkout pull/10562
$ git pull https://git.openjdk.org/jdk pull/10562/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10562

View PR using the GUI difftool:
$ git pr show -t 10562

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10562.diff

[bridgekeeper]

👋 Welcome back alanb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@AlanBateman The following labels will be automatically applied to this pull request:

• core-libs
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (bc2c3f13)
• 00: Full (5ac95695)

[openjdk]

@AlanBateman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8291429: java/lang/Thread/virtual/ThreadAPI.java timed out on single core system

Reviewed-by: sspitsyn, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 2d25c0a: 8292280: Unused field 'keyListener' in BasicRadioButtonUI
• 0ad6803: 8293810: Remove granting of RuntimePermission("stopThread") from tests
• cf84c8e: 8292975: javac produces code that crashes with LambdaConversionException
• f3a44a4: 8075916: The regression-swing case failed as colored text is not shown on disabled checkbox and radio button with Nimbus LAF
• 37bd4fb: 6852577: Only for Nimbus LAF UIManager.get("PasswordField.echoChar") is null
• d4c9a88: 6560981: (cal) unused local variables in GregorianCalendar, etc.
• 5dd851d: 8281453: New optimization: convert ~x into -1-x when ~x is used in an arithmetic expression
• 85569e9: 8286037: Bump minimum boot jdk to JDK 19
• fef345b: 8293672: Update freetype md file
• 5c030cc: 8290973: In AffineTransform, equals(Object) is inconsistent with hashCode()
• ... and 1 more: https://git.openjdk.org/jdk/compare/73f06468ae7f9eebb8e37f2a534d2c19a8dac60d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[sspitsyn]

The update looks more clear.
Thanks,
Serguei

[plummercj]

If these tests are ever run with the virtual thread wrapper, will we end up being short a carrier thread? It's unclear to me if the tests will always have at least one unpinned carrier thread to work with.

[AlanBateman]

If these tests are ever run with the virtual thread wrapper, will we end up being short a carrier thread? It's unclear to me if the tests will always have at least one unpinned carrier thread to work with.

There's nothing inherit here that prevents use of the jtreg main wrapper with only a single carrier thread. That is, the helper class used by these tests will allow the underlying carrier to be released while waiting for the test running in another virtual thread to finish. However, there are a few issues that are problematic right now, one being that TestNG's test method invoker (specifically MethodInvocationHelper) pins. In time we will see if we have any similar issues with JUnit tests. So issues for the future if there the jtreg main wrapper is integrated, not an issue for this PR.

[AlanBateman]

/integrate

[openjdk]

Going to push as commit 1fda842.
Since your change was applied there have been 11 commits pushed to the master branch:

• 2d25c0a: 8292280: Unused field 'keyListener' in BasicRadioButtonUI
• 0ad6803: 8293810: Remove granting of RuntimePermission("stopThread") from tests
• cf84c8e: 8292975: javac produces code that crashes with LambdaConversionException
• f3a44a4: 8075916: The regression-swing case failed as colored text is not shown on disabled checkbox and radio button with Nimbus LAF
• 37bd4fb: 6852577: Only for Nimbus LAF UIManager.get("PasswordField.echoChar") is null
• d4c9a88: 6560981: (cal) unused local variables in GregorianCalendar, etc.
• 5dd851d: 8281453: New optimization: convert ~x into -1-x when ~x is used in an arithmetic expression
• 85569e9: 8286037: Bump minimum boot jdk to JDK 19
• fef345b: 8293672: Update freetype md file
• 5c030cc: 8290973: In AffineTransform, equals(Object) is inconsistent with hashCode()
• ... and 1 more: https://git.openjdk.org/jdk/compare/73f06468ae7f9eebb8e37f2a534d2c19a8dac60d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@AlanBateman Pushed as commit 1fda842.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.