Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8286037: Bump minimum boot jdk to JDK 19 #10564

Closed
wants to merge 2 commits into from

Conversation

vidmik
Copy link
Contributor

@vidmik vidmik commented Oct 4, 2022

With the JDK 19 GA out it's time to bump the minimum boot JDK version for mainline/JDK 20.

Testing: tier1-5, GHA builds


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10564/head:pull/10564
$ git checkout pull/10564

Update a local copy of the PR:
$ git checkout pull/10564
$ git pull https://git.openjdk.org/jdk pull/10564/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10564

View PR using the GUI difftool:
$ git pr show -t 10564

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10564.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 4, 2022

👋 Welcome back mikael! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 4, 2022

@vidmik The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Oct 4, 2022
@vidmik vidmik changed the title Draft: 8286037: Bump minimum boot jdk to JDK 19 8286037: Bump minimum boot jdk to JDK 19 Oct 5, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 5, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 5, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 5, 2022

@vidmik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286037: Bump minimum boot jdk to JDK 19

Reviewed-by: ctornqvi, darcy, shade, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • 536c9a5: 8294618: Update openjdk.java.net => openjdk.org
  • f531dae: 8294840: langtools OptionalDependencyTest.java use File.pathSeparator
  • ee6c391: 8289925: Shared code shouldn't reference the platform specific method frame::interpreter_frame_last_sp()
  • bd90c4c: 8282900: runtime/stringtable/StringTableCleaningTest.java verify unavailable at this moment
  • 979efd4: 8289004: investigate if SharedRuntime::get_java_tid parameter should be a JavaThread*
  • b9eeec2: 8294310: compare.sh fails on macos after JDK-8293550
  • 13a5000: 8294151: JFR: Unclear exception message when dumping stopped in memory recording
  • 8ebebbc: 8294368: Java incremental builds broken on Windows after JDK-8293116
  • 4bdd1c9: 8290964: C2 compilation fails with assert "non-reduction loop contains reduction nodes"
  • b4e74ae: 8294514: Wrong initialization of nmethod::_consts_offset for native nmethods
  • ... and 5 more: https://git.openjdk.org/jdk/compare/b2e86a620936cc0d65ca884ff2b6644998530354...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 5, 2022
@vidmik
Copy link
Contributor Author

vidmik commented Oct 6, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 6, 2022

Going to push as commit 85569e9.
Since your change was applied there have been 31 commits pushed to the master branch:

  • fef345b: 8293672: Update freetype md file
  • 5c030cc: 8290973: In AffineTransform, equals(Object) is inconsistent with hashCode()
  • f888aa9: 8293061: Combine CDSOptions and AppCDSOptions test utility classes
  • 73f0646: 8294839: Disable StressLongCountedLoop in compiler/loopopts/TestRemoveEmptyLoop.java
  • 2ceebf6: 8294456: Fix misleading-indentation warnings in core JDK libraries
  • ad7b7d4: 8294697: java/lang/Thread/virtual/ThreadAPI.testGetStackTrace2 failed with non-empty stack trace
  • e38ae8a: 8294759: Print actual lock/monitor ranking
  • 7012d4b: 8294837: unify Windows 2019 version check in os_windows and java_props_md
  • 8c15f77: 8270915: GIFImageReader disregards ignoreMetadata flag which causes memory exhaustion
  • 6029120: 8278086: [REDO] ImageIO.write() method will throw IndexOutOfBoundsException
  • ... and 21 more: https://git.openjdk.org/jdk/compare/b2e86a620936cc0d65ca884ff2b6644998530354...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 6, 2022
@openjdk openjdk bot closed this Oct 6, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 6, 2022
@openjdk
Copy link

openjdk bot commented Oct 6, 2022

@vidmik Pushed as commit 85569e9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
5 participants