Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8294869: Correct failure of RemovedJDKInternals.java after JDK-8294618 #10580

Closed
wants to merge 1 commit into from

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented Oct 5, 2022

Fix strings matches to updated strings.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8294869: Correct failure of RemovedJDKInternals.java after JDK-8294618

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10580/head:pull/10580
$ git checkout pull/10580

Update a local copy of the PR:
$ git checkout pull/10580
$ git pull https://git.openjdk.org/jdk pull/10580/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10580

View PR using the GUI difftool:
$ git pr show -t 10580

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10580.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 5, 2022

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 5, 2022
@openjdk
Copy link

openjdk bot commented Oct 5, 2022

@jddarcy The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Oct 5, 2022
@openjdk
Copy link

openjdk bot commented Oct 5, 2022

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294869: Correct failure of RemovedJDKInternals.java after JDK-8294618

Reviewed-by: alanb, azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 87acfee: 8294397: Replace StringBuffer with StringBuilder within java.text
  • f2c5718: 8294734: Redundant override in AES implementation
  • 536c9a5: 8294618: Update openjdk.java.net => openjdk.org

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 5, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 5, 2022

Webrevs

@jddarcy
Copy link
Member Author

jddarcy commented Oct 5, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 5, 2022

Going to push as commit 0ec1838.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 87acfee: 8294397: Replace StringBuffer with StringBuilder within java.text
  • f2c5718: 8294734: Redundant override in AES implementation
  • 536c9a5: 8294618: Update openjdk.java.net => openjdk.org

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 5, 2022
@openjdk openjdk bot closed this Oct 5, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 5, 2022
@openjdk
Copy link

openjdk bot commented Oct 5, 2022

@jddarcy Pushed as commit 0ec1838.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jddarcy jddarcy deleted the JDK-8294869 branch June 10, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants