6560981: (cal) unused local variables in GregorianCalendar, etc.

[justin-curtis-lu]

Problem: Unused variables in GregorianCalendar, JapaneseImperialCalendar, and Base Calendar.

Fix: Removed all unused variables in bug description except normalizedYear in JapaneseImpericalCalendar.getActualMaximum.() as there was no matching unused variable within that method.

Additionally removed realDayOfYear in GregorianCalendar.computeFields.() due to redundancy.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-6560981: (cal) unused local variables in GregorianCalendar, etc.

Reviewers

• Naoto Sato (@naotoj - Reviewer)
• Brent Christian (@bchristi-git - Reviewer)
• Iris Clark (@irisclark - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10585/head:pull/10585
$ git checkout pull/10585

Update a local copy of the PR:
$ git checkout pull/10585
$ git pull https://git.openjdk.org/jdk pull/10585/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10585

View PR using the GUI difftool:
$ git pr show -t 10585

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10585.diff

[bridgekeeper]

👋 Welcome back justin-curtis-lu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@justin-curtis-lu The following labels will be automatically applied to this pull request:

• core-libs
• i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (a0ad42c4)

[naotoj]

LGTM

[openjdk]

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6560981: (cal) unused local variables in GregorianCalendar, etc.

Reviewed-by: naoto, bchristi, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• 5dd851d: 8281453: New optimization: convert ~x into -1-x when ~x is used in an arithmetic expression
• 85569e9: 8286037: Bump minimum boot jdk to JDK 19
• fef345b: 8293672: Update freetype md file
• 5c030cc: 8290973: In AffineTransform, equals(Object) is inconsistent with hashCode()
• f888aa9: 8293061: Combine CDSOptions and AppCDSOptions test utility classes
• 73f0646: 8294839: Disable StressLongCountedLoop in compiler/loopopts/TestRemoveEmptyLoop.java
• 2ceebf6: 8294456: Fix misleading-indentation warnings in core JDK libraries
• ad7b7d4: 8294697: java/lang/Thread/virtual/ThreadAPI.testGetStackTrace2 failed with non-empty stack trace
• e38ae8a: 8294759: Print actual lock/monitor ranking
• 7012d4b: 8294837: unify Windows 2019 version check in os_windows and java_props_md
• ... and 7 more: https://git.openjdk.org/jdk/compare/f2c57186a40bea4d5ad1c3ba010b59e552db624d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@naotoj, @bchristi-git, @irisclark) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[bchristi-git]

Looks fine

[justin-curtis-lu]

/integrate

[openjdk]

@justin-curtis-lu
Your change (at version a0ad42c) is now ready to be sponsored by a Committer.

[naotoj]

/sponsor

[openjdk]

Going to push as commit d4c9a88.
Since your change was applied there have been 17 commits pushed to the master branch:

• 5dd851d: 8281453: New optimization: convert ~x into -1-x when ~x is used in an arithmetic expression
• 85569e9: 8286037: Bump minimum boot jdk to JDK 19
• fef345b: 8293672: Update freetype md file
• 5c030cc: 8290973: In AffineTransform, equals(Object) is inconsistent with hashCode()
• f888aa9: 8293061: Combine CDSOptions and AppCDSOptions test utility classes
• 73f0646: 8294839: Disable StressLongCountedLoop in compiler/loopopts/TestRemoveEmptyLoop.java
• 2ceebf6: 8294456: Fix misleading-indentation warnings in core JDK libraries
• ad7b7d4: 8294697: java/lang/Thread/virtual/ThreadAPI.testGetStackTrace2 failed with non-empty stack trace
• e38ae8a: 8294759: Print actual lock/monitor ranking
• 7012d4b: 8294837: unify Windows 2019 version check in os_windows and java_props_md
• ... and 7 more: https://git.openjdk.org/jdk/compare/f2c57186a40bea4d5ad1c3ba010b59e552db624d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@naotoj @justin-curtis-lu Pushed as commit d4c9a88.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.