8295278: Add parallel class loading tests

[coleenp]

I moved the ParallelLoad test to a subdirectory, and created a new one called CallLoadClass that calls loadClass directly and then waits on the ClassLoader object, while another thread calls forName() to go through the SystemDictionary resolution.

I also made dedicated tests out of the bugs reported in
JDK-4699981 ClassCircularityError thrown without reason during class loading and
JDK-4670071 java.lang.ClassLoader.loadClassInternal(String) is too restrictive

Tested with tier1 on Oracle platforms. These tests are run in tier1.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8295278: Add parallel class loading tests

Reviewers

• Vladimir Ivanov (@iwanowww - Reviewer) ⚠️ Review applies to abab0205
• Calvin Cheung (@calvinccheung - Reviewer) ⚠️ Review applies to 796c7b45

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10587/head:pull/10587
$ git checkout pull/10587

Update a local copy of the PR:
$ git checkout pull/10587
$ git pull https://git.openjdk.org/jdk pull/10587/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10587

View PR using the GUI difftool:
$ git pr show -t 10587

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10587.diff

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (44892f2b)
• 01: Full - Incremental (796c7b45)
• 00: Full (abab0205)

[iwanowww]

Looks good.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295278: Add parallel class loading tests

Reviewed-by: vlivanov, ccheung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

• 2087424: 8295370: Update java.io.ObjectStreamField to use Class.descriptorString
• 8487c56: 8295294: Misc cleanups in runtime/InvocationTests
• 0043d58: 8293531: C2: some vectorapi tests fail assert "Not monotonic" with flag -XX:TypeProfileLevel=222
• 2e2a51e: 8295267: Improve G1 scan to merge ratio calculation
• dfcd9d5: 8295320: [BACKOUT] 8276687 Remove support for JDK 1.4.1 PerfData shared memory files
• 2da079c: 8294426: Two fingers tap generates wrong mouse modifiers on M2 MacBooks
• 449b52f: 8295158: G1: Increase card-based cost sample reporting threshold
• 312985e: 8295156: G1: Improve constant other time calculation
• 786ce1c: 8295024: Cyclic constructor error is non-deterministic and inconsistent
• 1efa93e: 8294844: Improve G1 young gen length revise trigger
• ... and 18 more: https://git.openjdk.org/jdk/compare/7e4868de7b0d3c20a35f06671ec0b68cfd441793...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[calvinccheung]

I looked at mostly the tests under CallLoadClass and have one comment. Thanks.

[calvinccheung]

Should success be set to false in this case?

[coleenp]

Yes, you're right, it should be false. We expect LinkageError in this case.

[coleenp]

Thanks for reviewing, Vladimir and Calvin.

[openjdk-notifier]

@coleenp Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

[calvinccheung]

Updates look good. Thanks.

[coleenp]

Thank you Vladimir and Calvin for the reviews, and @turbanoff for the suggestion to remove the unneeded space.
/integrate

[openjdk]

Going to push as commit 5d273b9.
Since your change was applied there have been 38 commits pushed to the master branch:

• 172006c: 8295333: G1: Remove unnecessary check in G1Policy::calculate_desired_eden_length_by_mmu
• 7743345: 8294314: Minimize disabled warnings in hotspot
• 552d8a2: 8295192: Use original configure command line when called from a script
• cf07eae: 8295020: javac emits incorrect code for for-each on an intersection type.
• b3bb3e6: 8295325: tools/jlink/plugins/SaveJlinkArgfilesPluginTest.java fails on Linux ppc64le
• 9005af3: 8295110: RISC-V: Mark out relocations as incompressible
• 74a51cc: 8292698: Improve performance of DataInputStream
• d3781ac: 8295009: RISC-V: Interpreter intrinsify Thread.currentThread()
• e7d0ab2: 8295379: ProblemList java/lang/Float/Binary16Conversion.java in Xcomp mode on x64
• 404e8de: 8294865: x86: Improve the code generation of MulVB and MulVL
• ... and 28 more: https://git.openjdk.org/jdk/compare/7e4868de7b0d3c20a35f06671ec0b68cfd441793...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit 5d273b9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.