Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8289561: java/lang/instrument/NativeMethodPrefixAgent.java fails with "ERROR: Injection failure: java.lang.UnsupportedOperationException: Records requires ASM8" #10589

Closed
wants to merge 1 commit into from

Conversation

alexmenkov
Copy link

@alexmenkov alexmenkov commented Oct 6, 2022

Test failure is a duplicate of JDK-8284777, but the test needs to be updated:

  • the test instruments all loaded classes, so need to updated ASM version to support records and permits;
    Instrumentor.addNativeMethodTrackingInjection is used only by this test;
  • return empty array from transforming does not cause test failure, added code to handle agent errors

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8289561: java/lang/instrument/NativeMethodPrefixAgent.java fails with "ERROR: Injection failure: java.lang.UnsupportedOperationException: Records requires ASM8"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10589/head:pull/10589
$ git checkout pull/10589

Update a local copy of the PR:
$ git checkout pull/10589
$ git pull https://git.openjdk.org/jdk pull/10589/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10589

View PR using the GUI difftool:
$ git pr show -t 10589

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10589.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 6, 2022

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 6, 2022
@openjdk
Copy link

openjdk bot commented Oct 6, 2022

@alexmenkov The following labels will be automatically applied to this pull request:

  • core-libs
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Oct 6, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 6, 2022

Webrevs

@alexmenkov
Copy link
Author

/label remove core-libs

@openjdk openjdk bot removed the core-libs core-libs-dev@openjdk.org label Oct 6, 2022
@openjdk
Copy link

openjdk bot commented Oct 6, 2022

@alexmenkov
The core-libs label was successfully removed.

@openjdk
Copy link

openjdk bot commented Oct 6, 2022

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289561: java/lang/instrument/NativeMethodPrefixAgent.java fails with "ERROR: Injection failure: java.lang.UnsupportedOperationException: Records requires ASM8"

Reviewed-by: lmesnik, cjplummer, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 78 new commits pushed to the master branch:

  • 1fda842: 8291429: java/lang/Thread/virtual/ThreadAPI.java timed out on single core system
  • 2d25c0a: 8292280: Unused field 'keyListener' in BasicRadioButtonUI
  • 0ad6803: 8293810: Remove granting of RuntimePermission("stopThread") from tests
  • cf84c8e: 8292975: javac produces code that crashes with LambdaConversionException
  • f3a44a4: 8075916: The regression-swing case failed as colored text is not shown on disabled checkbox and radio button with Nimbus LAF
  • 37bd4fb: 6852577: Only for Nimbus LAF UIManager.get("PasswordField.echoChar") is null
  • d4c9a88: 6560981: (cal) unused local variables in GregorianCalendar, etc.
  • 5dd851d: 8281453: New optimization: convert ~x into -1-x when ~x is used in an arithmetic expression
  • 85569e9: 8286037: Bump minimum boot jdk to JDK 19
  • fef345b: 8293672: Update freetype md file
  • ... and 68 more: https://git.openjdk.org/jdk/compare/375f02fb21ae37c381229e2a28b1f26e3cb926d4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 6, 2022
@plummercj
Copy link
Contributor

I wouldn't consider this a duplicate of JDK-8284777. It was caused changes to make println use ReentrantLock, which resulted in a CCE when a println was done from the transform method. The println often triggered loading of the class being transformed, usually the ExclusiveNode inner class. However, now it seems that ExclusiveNode is always loaded early enough that this circularity doesn't happen.

Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks,
Serguei

@alexmenkov
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 7, 2022

Going to push as commit c1166a3.
Since your change was applied there have been 83 commits pushed to the master branch:

  • a1747ef: 8294941: GHA: Cut down cross-compilation sysroots
  • 67210ab: 8286394: Address possibly lossy conversions in jdk.naming.dns
  • 7a194d3: 8290154: [JVMCI] partially implement JVMCI for RISC-V
  • b38bed6: 8294308: Allow dynamically choosing the MEMFLAGS of a type without ResourceObj
  • 118d93b: 8294907: Remove unused NativeLookup::dll_load
  • 1fda842: 8291429: java/lang/Thread/virtual/ThreadAPI.java timed out on single core system
  • 2d25c0a: 8292280: Unused field 'keyListener' in BasicRadioButtonUI
  • 0ad6803: 8293810: Remove granting of RuntimePermission("stopThread") from tests
  • cf84c8e: 8292975: javac produces code that crashes with LambdaConversionException
  • f3a44a4: 8075916: The regression-swing case failed as colored text is not shown on disabled checkbox and radio button with Nimbus LAF
  • ... and 73 more: https://git.openjdk.org/jdk/compare/375f02fb21ae37c381229e2a28b1f26e3cb926d4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 7, 2022
@openjdk openjdk bot closed this Oct 7, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 7, 2022
@openjdk
Copy link

openjdk bot commented Oct 7, 2022

@alexmenkov Pushed as commit c1166a3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@alexmenkov alexmenkov deleted the instr_prefix_test branch October 7, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
4 participants