Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8294907: Remove unused NativeLookup::dll_load #10595

Closed

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Oct 6, 2022

Trivial change of removing dead code.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10595/head:pull/10595
$ git checkout pull/10595

Update a local copy of the PR:
$ git checkout pull/10595
$ git pull https://git.openjdk.org/jdk pull/10595/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10595

View PR using the GUI difftool:
$ git pr show -t 10595

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10595.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 6, 2022

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8294907 8294907: Remove unused NativeLookup::dll_load Oct 6, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 6, 2022
@openjdk
Copy link

openjdk bot commented Oct 6, 2022

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Oct 6, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 6, 2022

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

Thanks for spotting and doing this cleanup.

@openjdk
Copy link

openjdk bot commented Oct 7, 2022

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294907: Remove unused NativeLookup::dll_load

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • d4c9a88: 6560981: (cal) unused local variables in GregorianCalendar, etc.
  • 5dd851d: 8281453: New optimization: convert ~x into -1-x when ~x is used in an arithmetic expression
  • 85569e9: 8286037: Bump minimum boot jdk to JDK 19
  • fef345b: 8293672: Update freetype md file
  • 5c030cc: 8290973: In AffineTransform, equals(Object) is inconsistent with hashCode()
  • f888aa9: 8293061: Combine CDSOptions and AppCDSOptions test utility classes

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 7, 2022
@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Oct 7, 2022

Going to push as commit 118d93b.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 1fda842: 8291429: java/lang/Thread/virtual/ThreadAPI.java timed out on single core system
  • 2d25c0a: 8292280: Unused field 'keyListener' in BasicRadioButtonUI
  • 0ad6803: 8293810: Remove granting of RuntimePermission("stopThread") from tests
  • cf84c8e: 8292975: javac produces code that crashes with LambdaConversionException
  • f3a44a4: 8075916: The regression-swing case failed as colored text is not shown on disabled checkbox and radio button with Nimbus LAF
  • 37bd4fb: 6852577: Only for Nimbus LAF UIManager.get("PasswordField.echoChar") is null
  • d4c9a88: 6560981: (cal) unused local variables in GregorianCalendar, etc.
  • 5dd851d: 8281453: New optimization: convert ~x into -1-x when ~x is used in an arithmetic expression
  • 85569e9: 8286037: Bump minimum boot jdk to JDK 19
  • fef345b: 8293672: Update freetype md file
  • ... and 2 more: https://git.openjdk.org/jdk/compare/73f06468ae7f9eebb8e37f2a534d2c19a8dac60d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 7, 2022
@openjdk openjdk bot closed this Oct 7, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 7, 2022
@openjdk
Copy link

openjdk bot commented Oct 7, 2022

@albertnetymk Pushed as commit 118d93b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the nativelookup-remove branch October 7, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
2 participants