Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8291443: Obsolete the PrintSharedDictionary flag #10596

Closed

Conversation

matias9927
Copy link
Contributor

@matias9927 matias9927 commented Oct 6, 2022

Obsoleted the unused PrintSharedDictionary flag and removed the flag from all tests. Verified with tier1-4 tests.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires a CSR request to be approved

Issues

  • JDK-8291443: Obsolete the PrintSharedDictionary flag
  • JDK-8294877: Obsolete the PrintSharedDictionary flag (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10596/head:pull/10596
$ git checkout pull/10596

Update a local copy of the PR:
$ git checkout pull/10596
$ git pull https://git.openjdk.org/jdk pull/10596/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10596

View PR using the GUI difftool:
$ git pr show -t 10596

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10596.diff

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Oct 6, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 6, 2022

👋 Welcome back matias9927! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 6, 2022

@matias9927 The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Oct 6, 2022
@matias9927 matias9927 marked this pull request as ready for review October 18, 2022 18:18
@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Oct 18, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 20, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 20, 2022

Webrevs

@iklam
Copy link
Member

iklam commented Oct 20, 2022

Should the issue title be "Obsolete the PrintSharedDictionary flag" instead, since we are not doing a complete removal yet?

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What you have looks good but the flag should also be deleted from:

./src/hotspot/share/cds/cds_globals.hpp

Thanks.

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@openjdk
Copy link

openjdk bot commented Oct 24, 2022

@matias9927 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8291443: Obsolete the PrintSharedDictionary flag

Reviewed-by: dholmes, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 241 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dholmes-ora, @iklam) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 24, 2022
@dholmes-ora
Copy link
Member

As @iklam suggested it would be more precise to change the bug title to say "Obsolete" rather than "Remove". Thanks.

@matias9927 matias9927 changed the title 8291443: Remove the PrintSharedDictionary flag 8291443: Obsolete the PrintSharedDictionary flag Oct 24, 2022
@matias9927
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 24, 2022
@openjdk
Copy link

openjdk bot commented Oct 24, 2022

@matias9927
Your change (at version 55da087) is now ready to be sponsored by a Committer.

@iklam
Copy link
Member

iklam commented Oct 24, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 24, 2022

Going to push as commit fefbddf.
Since your change was applied there have been 241 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 24, 2022
@openjdk openjdk bot closed this Oct 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 24, 2022
@openjdk
Copy link

openjdk bot commented Oct 24, 2022

@iklam @matias9927 Pushed as commit fefbddf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants