-
Notifications
You must be signed in to change notification settings - Fork 5.9k
8294941: GHA: Cut down cross-compilation sysroots #10601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 17 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thanks! If any build-dev folks ack this, I can integrate this today :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me. Nice space savings!
Thanks! /integrate |
Going to push as commit a1747ef.
Your commit was automatically rebased without conflicts. |
In GHA cross-compilation, we don't need everything from the sysroot, because we use native compilers for the compilation. Therefore, we can cut them even deeper and reclaim significant amount of cache space. This would also make cache eviction less likely, which saves time on recreating the sysroots when that happens.
Current sysroots take about 300M per arch, which quickly multiplies up for multiple arches (we build 5 now), users (ballparking at about 200 active contributors). This amounts to about 1500M caches per job, and 300G in caches across our org for a single JDK tree. Update releases also use GHA for their testing, but the number of contributors there is lower. Still, I think it slides to TB territory now.
In my local tests, new aarch64 sysroot tar.gz gets reduced from 315M to just 85M, about 3.7x improvement. Even deeper cuts are possible, but they would affect the redundant
.so
-s in/usr/lib/${arch}/
. That would be much more fragile to do and might affect our builds. Therefore, I stopped at doing just these.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10601/head:pull/10601
$ git checkout pull/10601
Update a local copy of the PR:
$ git checkout pull/10601
$ git pull https://git.openjdk.org/jdk pull/10601/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10601
View PR using the GUI difftool:
$ git pr show -t 10601
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10601.diff