8294958: java/net/httpclient/ConnectTimeout tests are slow

[djelinski]

Please review this test-only change that improves the execution times of ConnectTimeout tests:

• ConnectTimeoutHandshakeAsync and ConnectTimeoutHandshakeSync: before this change each one takes 80+ seconds to execute.
• ConnectTimeoutNoProxyAsync, ConnectTimeoutNoProxySync, ConnectTimeoutWithProxyAsync, ConnectTimeoutWithProxySync: before this change each one takes 50+ seconds to execute.

After this change each test completes successfully under 10 seconds.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8294958: java/net/httpclient/ConnectTimeout tests are slow

Reviewers

• Daniel Fuchs (@dfuch - Reviewer)
• Aleksei Efimov (@AlekseiEfimov - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10605/head:pull/10605
$ git checkout pull/10605

Update a local copy of the PR:
$ git checkout pull/10605
$ git pull https://git.openjdk.org/jdk pull/10605/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10605

View PR using the GUI difftool:
$ git pr show -t 10605

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10605.diff

[bridgekeeper]

👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@djelinski The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (39d2b95a)

[dfuch]

LGTM. Reducing the number of values produced by the data providers seems like a good strategy.

[openjdk]

@djelinski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294958: java/net/httpclient/ConnectTimeout tests are slow

Reviewed-by: dfuchs, aefimov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 49 new commits pushed to the master branch:

• 6ed74ef: 8295005: compiler/loopopts/TestRemoveEmptyLoop.java fails with release VMs after JDK-8294839
• 8a148bc: 8294848: Unnecessary SSLCipher dispose implementations
• 8713dfa: 8294541: java/io/BufferedInputStream/TransferTo.java fails with OOME
• 542cc60: 8294366: RISC-V: Partially mark out incompressible regions
• 495c043: 7124710: interleaved RedefineClasses() and RetransformClasses() calls may have a problem
• d39d8c8: 8170389: java.text.DigitList.getDouble() : Controversy between javadoc and code
• 3466e99: 8294691: dynamicArchive/RelativePath.java is running other test case
• 823b53d: 8294987: Streamline DerOutputStream write
• 6a266c4: 8292879: com/sun/jdi/ClassUnloadEventTest.java failed due to classes not unloading
• fe7a461: 8294920: Missing SP value in Linux x86_32 thread context
• ... and 39 more: https://git.openjdk.org/jdk/compare/8ebebbce32c7021cc0983dece4bb2644c79e64aa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[AlekseiEfimov]

The change looks reasonable to me. All these tests have been added via JDK-8208391 enhancement, and it seems that the removed timeout cases don't hold any specific meaning, therefore looks good to remove them.

[djelinski]

/integrate

[openjdk]

Going to push as commit fe70487.
Since your change was applied there have been 62 commits pushed to the master branch:

• 97f1321: 8294356: IGV: scheduled graphs contain duplicated elements
• 5e05e42: 8294901: remove pre-VS2017 checks in Windows related coding
• e775acf: 8293986: Incorrect double-checked locking in com.sun.beans.introspect.ClassInfo
• 9d116ec: 8294262: AArch64: compiler/vectorapi/TestReverseByteTransforms.java test failed on SVE machine
• 4b17d28: 8294261: AArch64: Use pReg instead of pRegGov when possible
• 891156a: 8295003: Do not mention applets in the "java.awt.color" package
• e6c33e6: 8295014: Remove unnecessary explicit casts to void* in CHeapObjBase
• 1bfcc27: 8294931: JFR: Simplify SettingInfo
• eb90c4f: 8294377: Prepare to stop auto-inheriting documentation for subclasses of exceptions whose documentation is inherited
• 4df4a1f: 8287832: jdk/jfr/event/runtime/TestActiveSettingEvent.java failed with "Expected two batches of Active Setting events"
• ... and 52 more: https://git.openjdk.org/jdk/compare/8ebebbce32c7021cc0983dece4bb2644c79e64aa...master

Your commit was automatically rebased without conflicts.

[openjdk]

@djelinski Pushed as commit fe70487.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.