8288415: java/awt/PopupMenu/PopupMenuLocation.java is unstable in MacOS machines #10606
Conversation
|
👋 Welcome back mvs! A progress list of the required criteria for merging this PR into |
|
@manukumarvs The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
| Dimension screenSize = Toolkit.getDefaultToolkit().getScreenSize(); | ||
| try { | ||
| ImageIO.write(robot.createScreenCapture( | ||
| new Rectangle(0, 0, screenSize.width, screenSize.height)), |
There was a problem hiding this comment.
This may capture the default screen while the frame is currently visible on another one.
There was a problem hiding this comment.
But, is there any way we can capture the current screen where the frame is displayed?
There was a problem hiding this comment.
You can pass coordinates/bounds of that screen to the createScreenCapture.
There was a problem hiding this comment.
Will do that in a new PR as something went wrong with this and some unnecessary commits got added
…core system Reviewed-by: sspitsyn, cjplummer
Reviewed-by: dholmes
…sourceObj Reviewed-by: coleenp, stefank, kbarrett
Reviewed-by: ihse, dnsimon, yadongwang
Reviewed-by: rriggs, aefimov
Reviewed-by: clanger, erikj
… "ERROR: Injection failure: java.lang.UnsupportedOperationException: Records requires ASM8" Reviewed-by: lmesnik, cjplummer, sspitsyn
…allocator or Cleaner fails with OOME Reviewed-by: alanb
Reviewed-by: cjplummer, sspitsyn
…not unloading Reviewed-by: dholmes, coleenp, sspitsyn
Reviewed-by: jnimeh, ascarpino
Reviewed-by: iklam, ccheung
…c and code Reviewed-by: naoto, lancea
… may have a problem Reviewed-by: sspitsyn, dcubed
Reviewed-by: fyang, yadongwang
Reviewed-by: alanb
Reviewed-by: xuelei, valeriep, wetmore
…e VMs after JDK-8294839 Reviewed-by: chagedorn, epeter
…ch5 for WIndowLookAndFeel Reviewed-by: aivanov, tr
Reviewed-by: erikj
…tManager::lease Reviewed-by: egahlin
…h "Expected two batches of Active Setting events" Reviewed-by: egahlin
… of exceptions whose documentation is inherited Reviewed-by: jjg
Reviewed-by: mgronlun
Reviewed-by: jsjolen, dholmes, stefank
Reviewed-by: aivanov, prr
Reviewed-by: ngasson, xgong
…est failed on SVE machine Reviewed-by: aph, njian
….ClassInfo Reviewed-by: serb
Reviewed-by: dholmes, mdoerr, kbarrett
Reviewed-by: chagedorn, thartmann
Reviewed-by: dfuchs, aefimov
Reviewed-by: dfuchs
Reviewed-by: mdoerr, shade
…ed value of shouldCommit() Reviewed-by: mgronlun
…ileView Reviewed-by: aivanov
Reviewed-by: iklam, rkennke
…obox and selection textarea. Reviewed-by: jdv, tr, psadhukhan
|
You did something wrong, now there are 40 commits and 126 files changed. It doesn't look right. Merging master should result in one commit only even though it brings multiple commits into the history. |
Yea, I have seen that. I tried to fix it, but its not working, will delete this branch and create a new one. |
java/awt/PopupMenu/PopupMenuLocation.java seems to be unstable in MacOS machines, especially in MacOSX 12 & 13 machines. It seems to be a testbug as adding some stability improvements fixes the issue. It intermittently fails in CI causing some noise. This test was already problem listed in windows due to an umbrella bug JDK-8238720. This fix doesn't cover the Windows issue, so the problem listing in windows will remain same.
Fix:
Some stability improvements have been done and the test has been run 100 times per platform in mach5 and got full PASS.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10606/head:pull/10606$ git checkout pull/10606Update a local copy of the PR:
$ git checkout pull/10606$ git pull https://git.openjdk.org/jdk pull/10606/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10606View PR using the GUI difftool:
$ git pr show -t 10606Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10606.diff