8294987: Streamline DerOutputStream write

[wangweij]

Return this in various output methods so you can write something like

        new DerOutputStream().putInteger(1)
                .putOctetString("12345".getBytes(StandardCharsets.UTF_8))
                .write(AlgorithmId.get("ed25519"))
                .writeImplicit((byte)0x80, new DerOutputStream().putUnalignedBitString(ba)).toByteArray();

No regression test. Trivial pure enhancement.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8294987: Streamline DerOutputStream write

Reviewers

• Jamil Nimeh (@jnimeh - Reviewer) ⚠️ Review applies to 298f5f20
• Anthony Scarpino (@ascarpino - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10608/head:pull/10608
$ git checkout pull/10608

Update a local copy of the PR:
$ git checkout pull/10608
$ git pull https://git.openjdk.org/jdk pull/10608/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10608

View PR using the GUI difftool:
$ git pr show -t 10608

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10608.diff

[bridgekeeper]

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@wangweij The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (eeb131d3)
• 00: Full (298f5f20)

[jnimeh]

Looks good to me

[openjdk]

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294987: Streamline DerOutputStream write

Reviewed-by: jnimeh, ascarpino

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 127 new commits pushed to the master branch:

• 6a266c4: 8292879: com/sun/jdi/ClassUnloadEventTest.java failed due to classes not unloading
• fe7a461: 8294920: Missing SP value in Linux x86_32 thread context
• 4cbac40: 8294717: (bf) DirectByteBuffer constructor will leak if allocating Deallocator or Cleaner fails with OOME
• c1166a3: 8289561: java/lang/instrument/NativeMethodPrefixAgent.java fails with "ERROR: Injection failure: java.lang.UnsupportedOperationException: Records requires ASM8"
• a1747ef: 8294941: GHA: Cut down cross-compilation sysroots
• 67210ab: 8286394: Address possibly lossy conversions in jdk.naming.dns
• 7a194d3: 8290154: [JVMCI] partially implement JVMCI for RISC-V
• b38bed6: 8294308: Allow dynamically choosing the MEMFLAGS of a type without ResourceObj
• 118d93b: 8294907: Remove unused NativeLookup::dll_load
• 1fda842: 8291429: java/lang/Thread/virtual/ThreadAPI.java timed out on single core system
• ... and 117 more: https://git.openjdk.org/jdk/compare/37f83b9b8e007cd1153502540e9b1bf3cc713646...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[ascarpino]

There are a number of methods that call 'write()' then call 'return this;' they could just be 'return write()', but if that's a style you prefer, that is fine.

[wangweij]

There are a number of methods that call 'write()' then call 'return this;' they could just be 'return write()', but if that's a style you prefer, that is fine.

Not my style. Will fix them.

[wangweij]

/integrate

[openjdk]

Going to push as commit 823b53d.
Since your change was applied there have been 127 commits pushed to the master branch:

• 6a266c4: 8292879: com/sun/jdi/ClassUnloadEventTest.java failed due to classes not unloading
• fe7a461: 8294920: Missing SP value in Linux x86_32 thread context
• 4cbac40: 8294717: (bf) DirectByteBuffer constructor will leak if allocating Deallocator or Cleaner fails with OOME
• c1166a3: 8289561: java/lang/instrument/NativeMethodPrefixAgent.java fails with "ERROR: Injection failure: java.lang.UnsupportedOperationException: Records requires ASM8"
• a1747ef: 8294941: GHA: Cut down cross-compilation sysroots
• 67210ab: 8286394: Address possibly lossy conversions in jdk.naming.dns
• 7a194d3: 8290154: [JVMCI] partially implement JVMCI for RISC-V
• b38bed6: 8294308: Allow dynamically choosing the MEMFLAGS of a type without ResourceObj
• 118d93b: 8294907: Remove unused NativeLookup::dll_load
• 1fda842: 8291429: java/lang/Thread/virtual/ThreadAPI.java timed out on single core system
• ... and 117 more: https://git.openjdk.org/jdk/compare/37f83b9b8e007cd1153502540e9b1bf3cc713646...master

Your commit was automatically rebased without conflicts.

[openjdk]

@wangweij Pushed as commit 823b53d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.