8294997: Improve ECC math operations #10614

djelinski · 2022-10-07T21:11:39Z

This patch rewrites some BigInteger and curve point operations used in EC calculations:

coefficient * 2^power is equivalent to coefficient << power
number mod 2^n is equivalent to number & (2^n-1)
pair of IntegerModuloP operations:
t2 = t1+t1
t1 = t1+t2
is equivalent to t1=t1*3, which is now implemented more efficiently.

Benchmarked the code using not-yet-merged benchmark from #10544. Results on x64 before:

Benchmark        (messageLength)   Mode  Cnt     Score   Error  Units
Signatures.sign               64  thrpt   15  1578.907 ± 1.522  ops/s

After:

Benchmark        (messageLength)   Mode  Cnt     Score   Error  Units
Signatures.sign               64  thrpt   15  1679.495 ± 3.883  ops/s

Greatest part of the improvement is related to ECOperations changes; BigInteger modifications provide only marginal gains (1584 ops/s without ECOperations changes).

Tier1-3 tests continue to pass.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8294997: Improve ECC math operations

Reviewers

Xue-Lei Andrew Fan (@XueleiFan - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10614/head:pull/10614
$ git checkout pull/10614

Update a local copy of the PR:
$ git checkout pull/10614
$ git pull https://git.openjdk.org/jdk pull/10614/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10614

View PR using the GUI difftool:
$ git pr show -t 10614

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10614.diff

bridgekeeper · 2022-10-08T15:37:01Z

👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-10-08T19:43:33Z

@djelinski The following labels will be automatically applied to this pull request:

build
security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-10-11T07:31:18Z

Webrevs

01: Full - Incremental (ecc7f41b)
00: Full (effc1a65)

ferakocz · 2022-10-11T16:24:25Z

In src/java.base/share/classes/sun/security/provider/DSAParameterGenerator.java there a still some mod(Biginteger.TWO.pow(...)) type subexpressions, e.g. in lines 214, 220, 231, 240 (not that it matters much).

src/java.base/share/classes/sun/security/provider/DSAParameterGenerator.java

XueleiFan · 2022-10-11T17:35:01Z

src/java.base/share/classes/sun/security/util/math/intpoly/IntegerPolynomial.java

@@ -329,9 +329,10 @@ private void setLimbsValue(BigInteger v, long[] limbs) {
    }

    protected void setLimbsValuePositive(BigInteger v, long[] limbs) {
-        BigInteger mod = BigInteger.valueOf(1 << bitsPerLimb);
+        assert bitsPerLimb < 32;


I may have this assert in the constructors as it is a final field.

I added it here as a comment explaining why using intValue is okay here; it wouldn't serve its purpose if I moved it elsewhere.
Asserts are eliminated by the compiler by default anyway. If you think this assert shouldn't be here, I can replace it with a normal comment.

The assert feature can be turned on. I may prefer to use comment if that's the intention. I'm fine to you want to keep it.

magicus · 2022-10-12T11:29:54Z

/label -build

openjdk · 2022-10-12T11:30:41Z

@magicus
The build label was successfully removed.

openjdk · 2022-10-12T14:57:44Z

@djelinski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294997: Improve ECC math operations

Reviewed-by: xuelei

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 96 new commits pushed to the master branch:

760a260: 8295213: Run GHA manually with user-specified make and configure arguments
8402260: 8295198: Update more openjdk.java.net => openjdk.org URLs
c357b59: 8295211: Fix autoconf 2.71 warning "AC_CHECK_HEADERS: you should use literals"
8607842: 8295205: Add jcheck whitespace checking for markdown files
cb62f1c: 8295218: New KeepAliveTest.java has invalid copyright notice
9cf6651: 8294238: ZGC: Move CLD claimed mark clearing
adaff7d: 8294900: Refactor ZObjArrayAllocator
86ec158: 8291226: Create Test Cases to cover scenarios for JDK-8278067
94ec729: 8263044: jdk/jfr/jvm/TestDumpOnCrash.java timed out
bdb4ed0: 8294580: frame::interpreter_frame_print_on() crashes if free BasicObjectLock exists in frame
... and 86 more: https://git.openjdk.org/jdk/compare/8ebebbce32c7021cc0983dece4bb2644c79e64aa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

djelinski · 2022-10-13T10:14:35Z

/integrate

openjdk · 2022-10-13T10:16:51Z

Going to push as commit 2f60675.
Since your change was applied there have been 107 commits pushed to the master branch:

94caecb: 8294906: Memory leak in PKCS11 NSS TLS server
03e63a2: 8295225: [JVMCI] codeStart should be cleared when entryPoint is cleared
26ac836: 8291638: Keep-Alive timeout of 0 should close connection immediately
6ae7e4d: 8293984: Unnecessary Vector usage in PropertyEditorSupport
cd1357b: 8295229: Try to verify gtest version
90fb9a0: 8295102: Always load @lambda-form-invoker lines from default classlist
ac19414: 8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance
1961e81: 8289509: Improve test coverage for XPath Axes: descendant, descendant-or-self, following, following-sibling
5699041: 8294772: Remove workaround in os::dll_address_to_library_name
d125265: 8277970: Test jdk/sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java fails with "tag mismatch"
... and 97 more: https://git.openjdk.org/jdk/compare/8ebebbce32c7021cc0983dece4bb2644c79e64aa...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-10-13T10:17:07Z

@djelinski Pushed as commit 2f60675.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

djelinski added 5 commits October 7, 2022 17:58

Remove biginteger modulo operation

2140236

Simplify math

5146c8b

Simplify mod

c12635a

Simplify multiplication

4a73935

Remove commented out code

effc1a6

openjdk bot changed the title ~~8294997~~ 8294997: Improve ECC math operations Oct 8, 2022

openjdk bot added security security-dev@openjdk.org build build-dev@openjdk.org labels Oct 8, 2022

djelinski marked this pull request as ready for review October 11, 2022 07:24

openjdk bot added the rfr Pull request is ready for review label Oct 11, 2022

XueleiFan reviewed Oct 11, 2022

View reviewed changes

openjdk bot removed the build build-dev@openjdk.org label Oct 12, 2022

djelinski added 2 commits October 12, 2022 14:36

Revert DSA changes

5925c53

Update copyright year

ecc7f41

XueleiFan approved these changes Oct 12, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 12, 2022

openjdk bot added the integrated Pull request has been integrated label Oct 13, 2022

openjdk bot closed this Oct 13, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 13, 2022

djelinski deleted the reduce-tls-garbage branch October 20, 2022 10:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8294997: Improve ECC math operations #10614

8294997: Improve ECC math operations #10614

djelinski commented Oct 7, 2022 •

edited by openjdk bot

Loading

bridgekeeper bot commented Oct 8, 2022

openjdk bot commented Oct 8, 2022

mlbridge bot commented Oct 11, 2022 •

edited

Loading

ferakocz commented Oct 11, 2022

XueleiFan Oct 11, 2022

djelinski Oct 12, 2022

XueleiFan Oct 12, 2022 •

edited

Loading

magicus commented Oct 12, 2022

openjdk bot commented Oct 12, 2022

openjdk bot commented Oct 12, 2022

djelinski commented Oct 13, 2022

openjdk bot commented Oct 13, 2022

openjdk bot commented Oct 13, 2022

8294997: Improve ECC math operations #10614

8294997: Improve ECC math operations #10614

Conversation

djelinski commented Oct 7, 2022 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Oct 8, 2022

openjdk bot commented Oct 8, 2022

mlbridge bot commented Oct 11, 2022 • edited Loading

Webrevs

ferakocz commented Oct 11, 2022

XueleiFan Oct 11, 2022

Choose a reason for hiding this comment

djelinski Oct 12, 2022

Choose a reason for hiding this comment

XueleiFan Oct 12, 2022 • edited Loading

Choose a reason for hiding this comment

magicus commented Oct 12, 2022

openjdk bot commented Oct 12, 2022

openjdk bot commented Oct 12, 2022

djelinski commented Oct 13, 2022

openjdk bot commented Oct 13, 2022

openjdk bot commented Oct 13, 2022

djelinski commented Oct 7, 2022 •

edited by openjdk bot

Loading

mlbridge bot commented Oct 11, 2022 •

edited

Loading

XueleiFan Oct 12, 2022 •

edited

Loading