Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295003: Do not mention applets in the "java.awt.color" package #10616

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Oct 7, 2022

The usage of "applets" are replaced by the "applications" in the "java.awt.color" package.
If there are no objections I'll skip the CSR for this small cleanup.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295003: Do not mention applets in the "java.awt.color" package

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10616/head:pull/10616
$ git checkout pull/10616

Update a local copy of the PR:
$ git checkout pull/10616
$ git pull https://git.openjdk.org/jdk pull/10616/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10616

View PR using the GUI difftool:
$ git pr show -t 10616

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10616.diff

@mrserb mrserb marked this pull request as ready for review October 8, 2022 02:46
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 8, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 8, 2022
@openjdk
Copy link

openjdk bot commented Oct 8, 2022

@mrserb The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Oct 8, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 8, 2022

Webrevs

Copy link
Member

@aivanov-jdk aivanov-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

As for CSR, applets are deprecated, it looks fine to me to remove the reference to them. Yet I suggest that you wait for other opinions.

@openjdk
Copy link

openjdk bot commented Oct 10, 2022

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295003: Do not mention applets in the "java.awt.color" package

Reviewed-by: aivanov, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 1bfcc27: 8294931: JFR: Simplify SettingInfo
  • eb90c4f: 8294377: Prepare to stop auto-inheriting documentation for subclasses of exceptions whose documentation is inherited
  • 4df4a1f: 8287832: jdk/jfr/event/runtime/TestActiveSettingEvent.java failed with "Expected two batches of Active Setting events"
  • 35d17a0: 8293864: Kitchensink24HStress.java fails with SIGSEGV in JfrCheckpointManager::lease
  • c5f462e: 8294956: GHA: qemu-debootstrap is deprecated, use the regular one
  • 269252a: 8295007: javax/swing/JRadioButton/4314194/bug4314194.java fails in mach5 for WIndowLookAndFeel
  • 6ed74ef: 8295005: compiler/loopopts/TestRemoveEmptyLoop.java fails with release VMs after JDK-8294839
  • 8a148bc: 8294848: Unnecessary SSLCipher dispose implementations
  • 8713dfa: 8294541: java/io/BufferedInputStream/TransferTo.java fails with OOME
  • 542cc60: 8294366: RISC-V: Partially mark out incompressible regions
  • ... and 2 more: https://git.openjdk.org/jdk/compare/3466e999348696c8666afd7a59c6947f61fe4d6a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 10, 2022
Copy link
Contributor

@prrace prrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds fine to me.

@mrserb
Copy link
Member Author

mrserb commented Oct 11, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 11, 2022

Going to push as commit 891156a.
Since your change was applied there have been 13 commits pushed to the master branch:

  • e6c33e6: 8295014: Remove unnecessary explicit casts to void* in CHeapObjBase
  • 1bfcc27: 8294931: JFR: Simplify SettingInfo
  • eb90c4f: 8294377: Prepare to stop auto-inheriting documentation for subclasses of exceptions whose documentation is inherited
  • 4df4a1f: 8287832: jdk/jfr/event/runtime/TestActiveSettingEvent.java failed with "Expected two batches of Active Setting events"
  • 35d17a0: 8293864: Kitchensink24HStress.java fails with SIGSEGV in JfrCheckpointManager::lease
  • c5f462e: 8294956: GHA: qemu-debootstrap is deprecated, use the regular one
  • 269252a: 8295007: javax/swing/JRadioButton/4314194/bug4314194.java fails in mach5 for WIndowLookAndFeel
  • 6ed74ef: 8295005: compiler/loopopts/TestRemoveEmptyLoop.java fails with release VMs after JDK-8294839
  • 8a148bc: 8294848: Unnecessary SSLCipher dispose implementations
  • 8713dfa: 8294541: java/io/BufferedInputStream/TransferTo.java fails with OOME
  • ... and 3 more: https://git.openjdk.org/jdk/compare/3466e999348696c8666afd7a59c6947f61fe4d6a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 11, 2022
@openjdk openjdk bot closed this Oct 11, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 11, 2022
@openjdk
Copy link

openjdk bot commented Oct 11, 2022

@mrserb Pushed as commit 891156a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8295003 branch October 12, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants