Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295005: compiler/loopopts/TestRemoveEmptyLoop.java fails with release VMs after JDK-8294839 #10617

Closed
wants to merge 2 commits into from

Conversation

DamonFool
Copy link
Member

@DamonFool DamonFool commented Oct 8, 2022

Since we need to set -XX:StressLongCountedLoop=0 to avoid timeout of the test.
So only run it with debug VMs.

Thanks.
Best regards,
Jie


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295005: compiler/loopopts/TestRemoveEmptyLoop.java fails with release VMs after JDK-8294839

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10617/head:pull/10617
$ git checkout pull/10617

Update a local copy of the PR:
$ git checkout pull/10617
$ git pull https://git.openjdk.org/jdk pull/10617/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10617

View PR using the GUI difftool:
$ git pr show -t 10617

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10617.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 8, 2022

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 8, 2022
@openjdk
Copy link

openjdk bot commented Oct 8, 2022

@DamonFool The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Oct 8, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 8, 2022

Webrevs

@eme64
Copy link
Contributor

eme64 commented Oct 9, 2022

@DamonFool First, sorry for the silly mistake and thanks for fixing it.
If we still want to run this test on develop machines, we could alternatively simply use -XX:+IgnoreUnrecognizedVMOptions. On product builds the default is already -XX:StressLongCountedLoop=0.

@DamonFool
Copy link
Member Author

If we still want to run this test on develop machines, we could alternatively simply use -XX:+IgnoreUnrecognizedVMOptions. On product builds the default is already -XX:StressLongCountedLoop=0.

Thanks @eme64 for the review.

Right.
Since we can't change the default value of StressLongCountedLoop in product VMs, it's safe to do so.
Updated.
Thanks.

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Oct 10, 2022

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295005: compiler/loopopts/TestRemoveEmptyLoop.java fails with release VMs after JDK-8294839

Reviewed-by: chagedorn, epeter

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 8713dfa: 8294541: java/io/BufferedInputStream/TransferTo.java fails with OOME
  • 542cc60: 8294366: RISC-V: Partially mark out incompressible regions

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 10, 2022
Copy link
Contributor

@eme64 eme64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing it!
(FYI: I'm not a reviewer yet)

@DamonFool
Copy link
Member Author

Thanks @chhagedorn and @eme64 .
/integrate

@openjdk
Copy link

openjdk bot commented Oct 10, 2022

Going to push as commit 6ed74ef.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 8a148bc: 8294848: Unnecessary SSLCipher dispose implementations
  • 8713dfa: 8294541: java/io/BufferedInputStream/TransferTo.java fails with OOME
  • 542cc60: 8294366: RISC-V: Partially mark out incompressible regions

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 10, 2022
@openjdk openjdk bot closed this Oct 10, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 10, 2022
@openjdk
Copy link

openjdk bot commented Oct 10, 2022

@DamonFool Pushed as commit 6ed74ef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@DamonFool DamonFool deleted the JDK-8295005 branch October 10, 2022 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants