8295016: Make the arraycopy_epilogue signature consistent with its usage

[caizixian]

The second register argument should be named count. Please see the following usage.

jdk/src/hotspot/cpu/riscv/stubGenerator_riscv.cpp

Line 1138 in 495c043

bs->arraycopy_epilogue(_masm, decorators, is_oop, d, count, t0, RegSet());

jdk/src/hotspot/cpu/riscv/stubGenerator_riscv.cpp

Line 1210 in 495c043

bs->arraycopy_epilogue(_masm, decorators, is_oop, d, count, t0, RegSet());

jdk/src/hotspot/cpu/riscv/stubGenerator_riscv.cpp

Line 1584 in 495c043

bs->arraycopy_epilogue(_masm, decorators, is_oop, start_to, count_save, t0, wb_post_saved_regs);

Update: also fix for AArch64.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8295016: Make the arraycopy_epilogue signature consistent with its usage

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10620/head:pull/10620
$ git checkout pull/10620

Update a local copy of the PR:
$ git checkout pull/10620
$ git pull https://git.openjdk.org/jdk pull/10620/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10620

View PR using the GUI difftool:
$ git pr show -t 10620

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10620.diff

[bridgekeeper]

Hi @caizixian, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user caizixian" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

@caizixian The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[caizixian]

/signed

[bridgekeeper]

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[caizixian]

@shipilev @RealFYang It seems that you have to be an OpenJDK author to have a Jira account to open issues. Is it possible that someone with access could open an issue on my behalf? Thanks!

[RealFYang]

@shipilev @RealFYang It seems that you have to be an OpenJDK author to have a Jira account to open issues. Is it possible that someone with access could open an issue on my behalf? Thanks!

Hi, I have created one for you: https://bugs.openjdk.org/browse/JDK-8295016

[shipilev]

Same problem exists in aarch64, please fix it there too?

[caizixian]

@shipilev fixed.

[RealFYang]

@caizixian : You should modify the title of this PR making it consistent with the title of the JBS issue.

[caizixian]

@caizixian : You should modify the title of this PR making it consistent with the title of the JBS issue.

Done

[shipilev]

This looks good to me. Bots would allow you to integrate once OCA clears.

[openjdk]

@caizixian This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295016: Make the arraycopy_epilogue signature consistent with its usage

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 97 new commits pushed to the master branch:

• 21a825e: 8288387: GetLocalXXX/SetLocalXXX spec should require suspending target thread
• 8d751de: 8295231: Move all linking of native libraries to make
• f300ec8: 8294546: document where javac differs when invoked via launcher and ToolProvider
• b269c51: 8295395: Linux Alpha Zero builds fail after JDK-8292591
• ae60599: 8295023: Interpreter(AArch64): Implement -XX:+PrintBytecodeHistogram and -XX:+PrintBytecodePairHistogram options
• 4d37ef2: 8295262: Build binutils out of source tree
• 0919a3a: 8294186: AArch64: VectorMaskToLong failed on SVE2 machine with -XX:UseSVE=1
• ec2981b: 8293711: Factor out size parsing functions from arguments.cpp
• 5d273b9: 8295278: Add parallel class loading tests
• 172006c: 8295333: G1: Remove unnecessary check in G1Policy::calculate_desired_eden_length_by_mmu
• ... and 87 more: https://git.openjdk.org/jdk/compare/9d116ec147a3182a9c831ffdce02c98da8c5031d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (983884c3)

[caizixian]

/integrate

[openjdk]

@caizixian
Your change (at version 983884c) is now ready to be sponsored by a Committer.

[RealFYang]

/sponsor

[openjdk]

Going to push as commit 692cdab.
Since your change was applied there have been 97 commits pushed to the master branch:

• 21a825e: 8288387: GetLocalXXX/SetLocalXXX spec should require suspending target thread
• 8d751de: 8295231: Move all linking of native libraries to make
• f300ec8: 8294546: document where javac differs when invoked via launcher and ToolProvider
• b269c51: 8295395: Linux Alpha Zero builds fail after JDK-8292591
• ae60599: 8295023: Interpreter(AArch64): Implement -XX:+PrintBytecodeHistogram and -XX:+PrintBytecodePairHistogram options
• 4d37ef2: 8295262: Build binutils out of source tree
• 0919a3a: 8294186: AArch64: VectorMaskToLong failed on SVE2 machine with -XX:UseSVE=1
• ec2981b: 8293711: Factor out size parsing functions from arguments.cpp
• 5d273b9: 8295278: Add parallel class loading tests
• 172006c: 8295333: G1: Remove unnecessary check in G1Policy::calculate_desired_eden_length_by_mmu
• ... and 87 more: https://git.openjdk.org/jdk/compare/9d116ec147a3182a9c831ffdce02c98da8c5031d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealFYang @caizixian Pushed as commit 692cdab.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.