Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295013: OopStorage should derive from CHeapObjBase #10622

Closed
wants to merge 3 commits into from

Conversation

kimbarrett
Copy link

@kimbarrett kimbarrett commented Oct 9, 2022

Please review this change to OopStorage to derive from CHeapObjBase instead of
providing its own operator new and operator delete.

We also add OopStorage::create factory, so the MEMFLAGS used to allocate the
storage object will be the same as that passed to its constructor. This
required a bunch of fairly mechanical updates to relevant gtests.

While I was there, also made OopStorage noncopyable.

Testing: mach5 tier1


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295013: OopStorage should derive from CHeapObjBase

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10622/head:pull/10622
$ git checkout pull/10622

Update a local copy of the PR:
$ git checkout pull/10622
$ git pull https://git.openjdk.org/jdk pull/10622/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10622

View PR using the GUI difftool:
$ git pr show -t 10622

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10622.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 9, 2022

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 9, 2022
@openjdk
Copy link

openjdk bot commented Oct 9, 2022

@kimbarrett The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Oct 9, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 9, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 10, 2022

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295013: OopStorage should derive from CHeapObjBase

Reviewed-by: stefank, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 10, 2022
@kimbarrett
Copy link
Author

Thanks @stefank and @tschatzl for reviews.

@kimbarrett
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 11, 2022

Going to push as commit 94a9b04.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 11, 2022
@openjdk openjdk bot closed this Oct 11, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 11, 2022
@openjdk
Copy link

openjdk bot commented Oct 11, 2022

@kimbarrett Pushed as commit 94a9b04.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kimbarrett kimbarrett deleted the oopstorage-allocate branch October 11, 2022 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants