Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295025: (bf) ByteBuffer "Access to binary data" section suggests putFloat is void #10638

Closed
wants to merge 1 commit into from

Conversation

bplb
Copy link
Member

@bplb bplb commented Oct 10, 2022

In the "Access to binary data" section of the class specification of java.nio.ByteBuffer, change void putFloat to ByteBuffer putFloat.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8295025: (bf) ByteBuffer "Access to binary data" section suggests putFloat is void
  • JDK-8295101: (bf) ByteBuffer "Access to binary data" section suggests putFloat is void (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10638/head:pull/10638
$ git checkout pull/10638

Update a local copy of the PR:
$ git checkout pull/10638
$ git pull https://git.openjdk.org/jdk pull/10638/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10638

View PR using the GUI difftool:
$ git pr show -t 10638

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10638.diff

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Oct 10, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 10, 2022

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 10, 2022
@openjdk
Copy link

openjdk bot commented Oct 10, 2022

@bplb The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Oct 10, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 10, 2022

Webrevs

Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No normative changes so I don't think you need a CSR for this one.

@bplb
Copy link
Member Author

bplb commented Oct 13, 2022

/csr unneeded

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Oct 13, 2022
@openjdk
Copy link

openjdk bot commented Oct 13, 2022

@bplb determined that a CSR request is not needed for this pull request.

@openjdk
Copy link

openjdk bot commented Oct 13, 2022

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295025: (bf) ByteBuffer "Access to binary data" section suggests putFloat is void

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 57 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 13, 2022
@bplb
Copy link
Member Author

bplb commented Oct 13, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 13, 2022

Going to push as commit 18dd9ee.
Since your change was applied there have been 57 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 13, 2022
@openjdk openjdk bot closed this Oct 13, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 13, 2022
@openjdk
Copy link

openjdk bot commented Oct 13, 2022

@bplb Pushed as commit 18dd9ee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bplb bplb deleted the ByteBuffer-binary-data-8295025 branch November 1, 2022 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated nio nio-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants