Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8294841: G1: Refactor predict_base_elapsed_time_ms #10644

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Oct 11, 2022

Hi,

can I have reviews for this change that does some minor renaming?

Testing: local compilation, gha

Thanks,
Thomas


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8294841: G1: Refactor predict_base_elapsed_time_ms

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10644/head:pull/10644
$ git checkout pull/10644

Update a local copy of the PR:
$ git checkout pull/10644
$ git pull https://git.openjdk.org/jdk pull/10644/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10644

View PR using the GUI difftool:
$ git pr show -t 10644

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10644.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 11, 2022

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 11, 2022
@openjdk
Copy link

openjdk bot commented Oct 11, 2022

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Oct 11, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 11, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 11, 2022

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294841: G1: Refactor predict_base_elapsed_time_ms

Reviewed-by: ayang, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • fba763f: 8291519: jdk/jfr/api/event/TestShouldCommit.java failed with Unexpected value of shouldCommit()
  • 6053bf0: 8293782: Shenandoah: some tests failed on lock rank check
  • 4435d56: 8282395: URL.openConnection can throw IOOBE
  • fe70487: 8294958: java/net/httpclient/ConnectTimeout tests are slow

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 11, 2022
@tschatzl
Copy link
Contributor Author

Thanks @walulyai @albertnetymk for your reviews

/integrate

@openjdk
Copy link

openjdk bot commented Oct 12, 2022

Going to push as commit 461d903.
Since your change was applied there have been 23 commits pushed to the master branch:

  • 392f35d: 8295033: hsdis configure error when cross-compiling with --with-binutils-src
  • 16e0c59: 8294950: print_sys_devices_cpu_info doesn't use the provided buffer
  • 5ad126f: 8295012: Arena should not derive from CHeapObj
  • ab8c136: 8292898: [vectorapi] Unify vector mask cast operation
  • 2ceb80c: 8288043: Optimize FP to word/sub-word integral type conversion on X86 AVX2 platforms
  • 703a6ef: 8283699: Improve the peephole mechanism of hotspot
  • 94a9b04: 8295013: OopStorage should derive from CHeapObjBase
  • 3a980b9: 8295168: Remove superfluous period in @throws tag description
  • 9bb932c: 8295154: Documentation for RemoteExecutionControl.invoke(Method) inherits non-existent documentation
  • 945950d: 8295069: [PPC64] Performance regression after JDK-8290025
  • ... and 13 more: https://git.openjdk.org/jdk/compare/97f1321cb455b536f1e4e056dec693c24f39d641...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 12, 2022
@openjdk openjdk bot closed this Oct 12, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 12, 2022
@openjdk
Copy link

openjdk bot commented Oct 12, 2022

@tschatzl Pushed as commit 461d903.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the submit/8294841-predict-base-elapsed-time branch October 12, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants