Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8294842: Pass actual pending cards to G1Policy::update_young_length_bounds during young gen revise #10649

Closed

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Oct 11, 2022

Hi all,

can I have reviews for this change that passes the actual amount of pending cards to G1Policy::update_young_length_bounds instead of some prediction during young gen revising?
That improves predictions quite a bit.

Depends on PR#10647, so please review that one first.

Testing: gha, local testing, tier1-5 with other changes in this patch series, perf testing with other changes in this patch series


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8294842: Pass actual pending cards to G1Policy::update_young_length_bounds during young gen revise

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10649/head:pull/10649
$ git checkout pull/10649

Update a local copy of the PR:
$ git checkout pull/10649
$ git pull https://git.openjdk.org/jdk pull/10649/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10649

View PR using the GUI difftool:
$ git pr show -t 10649

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10649.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 11, 2022

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into pr/10647 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 11, 2022
@openjdk
Copy link

openjdk bot commented Oct 11, 2022

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Oct 11, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 11, 2022

Webrevs

@@ -194,11 +194,14 @@ uint G1Policy::calculate_desired_eden_length_by_mmu() const {
}

void G1Policy::update_young_length_bounds() {
update_young_length_bounds(_analytics->predict_rs_length());
// We have no measure of the number of pending cards in the thread buffers,
// assume these are very few.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

predict_pending_cards() includes the cards that were thread buffers. It is based on the cards that were processed, which is done after DCQS::concatenate_logs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the code:
G1Policy::record_concurrent_refinement_stats sets _pending_cards_at_gc_start = dcqs.num_cards(); record_concurrent_refinement_stats is called in G1Policy::record_young_collection_start; in G1YoungCollector::collect, record_young_collection_start is called before pre_evacuate_collection_set which calls G1BarrierSet::dirty_card_queue_set().concatenate_logs.

I seem to be missing something, can you clarify?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a bug. I even found and fixed it in some earlier version of my concurrent refinement changes. But it looks like I never extracted it out or even created a bug report for it, and there's no fix for it in my concurrent refinement PR. Drat!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll file a bug for that problem. I'd prefer this comment be removed, so it doesn't need to be tracked down for removal as part of fixing that bug. Your call on that.

src/hotspot/share/gc/g1/g1Policy.cpp Outdated Show resolved Hide resolved
@openjdk-notifier openjdk-notifier bot changed the base branch from pr/10647 to master October 13, 2022 12:03
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout submit/8294842-pass-down-pending-cards
git fetch https://git.openjdk.org/jdk master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

openjdk bot commented Oct 13, 2022

@tschatzl this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout submit/8294842-pass-down-pending-cards
git fetch https://git.openjdk.org/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added merge-conflict Pull request has merge conflict with target branch and removed rfr Pull request is ready for review labels Oct 13, 2022
@openjdk openjdk bot added rfr Pull request is ready for review and removed merge-conflict Pull request has merge conflict with target branch labels Oct 13, 2022
@openjdk
Copy link

openjdk bot commented Oct 13, 2022

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294842: Pass actual pending cards to G1Policy::update_young_length_bounds during young gen revise

Reviewed-by: kbarrett, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • 7133fc9: 7172359: HTML parser StackOverflowError on invalid HTML:
  • tag inside an
  • 3d75e88: 8295270: RISC-V: Clean up and refactoring for assembler functions
  • be3b335: 8295026: Remove unused fields in StyleSheet
  • 67046ae: 8276687: Remove support for JDK 1.4.1 PerfData shared memory files
  • b30d922: 8292876: Do not include the deprecated userinfo component of the URI in HTTP/2 headers
  • 2b4830a: 8295017: Remove Windows specific workaround in JLI_Snprintf
  • fdb74ed: 8295301: Problem list TrayIcon tests that fail on Ubuntu 22.04
  • 21407de: 8295173: (tz) Update Timezone Data to 2022e
  • f5f8df1: 8295295: CDS ArchivedEnumTest fails with StaticProperty::JAVA_LOCALE_USE_OLD_ISO_CODES
  • 18dd9ee: 8295025: (bf) ByteBuffer "Access to binary data" section suggests putFloat is void
  • ... and 3 more: https://git.openjdk.org/jdk/compare/7e4868de7b0d3c20a35f06671ec0b68cfd441793...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 13, 2022
Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@@ -194,11 +194,14 @@ uint G1Policy::calculate_desired_eden_length_by_mmu() const {
}

void G1Policy::update_young_length_bounds() {
update_young_length_bounds(_analytics->predict_rs_length());
// We have no measure of the number of pending cards in the thread buffers,
// assume these are very few.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll file a bug for that problem. I'd prefer this comment be removed, so it doesn't need to be tracked down for removal as part of fixing that bug. Your call on that.

@tschatzl
Copy link
Contributor Author

Thanks @kimbarrett @albertnetymk for your reviews

/integrate

@openjdk
Copy link

openjdk bot commented Oct 14, 2022

Going to push as commit f31c80d.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 7133fc9: 7172359: HTML parser StackOverflowError on invalid HTML:
  • tag inside an
  • 3d75e88: 8295270: RISC-V: Clean up and refactoring for assembler functions
  • be3b335: 8295026: Remove unused fields in StyleSheet
  • 67046ae: 8276687: Remove support for JDK 1.4.1 PerfData shared memory files
  • b30d922: 8292876: Do not include the deprecated userinfo component of the URI in HTTP/2 headers
  • 2b4830a: 8295017: Remove Windows specific workaround in JLI_Snprintf
  • fdb74ed: 8295301: Problem list TrayIcon tests that fail on Ubuntu 22.04
  • 21407de: 8295173: (tz) Update Timezone Data to 2022e
  • f5f8df1: 8295295: CDS ArchivedEnumTest fails with StaticProperty::JAVA_LOCALE_USE_OLD_ISO_CODES
  • 18dd9ee: 8295025: (bf) ByteBuffer "Access to binary data" section suggests putFloat is void
  • ... and 3 more: https://git.openjdk.org/jdk/compare/7e4868de7b0d3c20a35f06671ec0b68cfd441793...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 14, 2022
@openjdk openjdk bot closed this Oct 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 14, 2022
@openjdk
Copy link

openjdk bot commented Oct 14, 2022

@tschatzl Pushed as commit f31c80d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the submit/8294842-pass-down-pending-cards branch October 14, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants