8295149: Misnomer for_young_gc instead of for_young_only_phase in G1Analytics

[tschatzl]

Hi all,

please review this change that renames lots of for_young_gc parameters to for_young_only_phase to correspond to the actual meaning.

Depends on PR#10650, so please review that one first.

Testing: local compilation

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8295149: Misnomer for_young_gc instead of for_young_only_phase in G1Analytics

Reviewers

• Kim Barrett (@kimbarrett - Reviewer) ⚠️ Review applies to 34b02e0d
• Ivan Walulya (@walulyai - Reviewer) ⚠️ Review applies to 34b02e0d

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10651/head:pull/10651
$ git checkout pull/10651

Update a local copy of the PR:
$ git checkout pull/10651
$ git pull https://git.openjdk.org/jdk pull/10651/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10651

View PR using the GUI difftool:
$ git pr show -t 10651

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10651.diff

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into pr/10650 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full (578f66fa)
• 02: Full (e4a91fcc)
• 01: Full (ffe570a2)
• 00: Full (34b02e0d)

[kimbarrett]

Looks good.

[openjdk]

@tschatzl this pull request can not be integrated into pr/10650 due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout submit/8295149-misnomer-for-young-gc
git fetch https://git.openjdk.org/jdk pr/10650
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge pr/10650"
git push

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout submit/8295149-misnomer-for-young-gc
git fetch https://git.openjdk.org/jdk master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

⚠️ @tschatzl This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295149: Misnomer for_young_gc instead of for_young_only_phase in G1Analytics

Reviewed-by: kbarrett, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tschatzl]

Thanks @kimbarrett @walulyai for your reviews

/integrate

[openjdk]

Going to push as commit ef5210f.

[openjdk]

@tschatzl Pushed as commit ef5210f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.