8295156: G1: Improve constant other time calculation

[tschatzl]

Hi all,

can I have reviews for this change from Ivan that improves current constant other time calculation, allowing for better predictions?

After many years of changes to the garbage collection algorithm, moving around phases, the current calculation of constant other time became just wrong. This change fixes this.

Depends on PR#10652, please review that one first if not done yet.

Testing: Testing: gha, local testing, tier1-5 with other changes in this patch series, perf testing with other changes in this patch series

Thanks,
Thomas

/contributor add @walulyai
/contributor remove @tschatzl

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8295156: G1: Improve constant other time calculation

Reviewers

• Kim Barrett (@kimbarrett - Reviewer) ⚠️ Review applies to f4b3b5ab
• Ivan Walulya (@walulyai - Reviewer) ⚠️ Review applies to f4b3b5ab

Contributors

• Ivan Walulya <iwalulya@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10654/head:pull/10654
$ git checkout pull/10654

Update a local copy of the PR:
$ git checkout pull/10654
$ git pull https://git.openjdk.org/jdk pull/10654/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10654

View PR using the GUI difftool:
$ git pr show -t 10654

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10654.diff

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into pr/10652 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl
Contributor Ivan Walulya <iwalulya@openjdk.org> successfully added.

[openjdk]

@tschatzl Contributor Thomas Schatzl <tschatzl@openjdk.org> was not found.
Current additional contributors are:

• Ivan Walulya <iwalulya@openjdk.org>

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (92823188)
• 02: Full (aee4436e)
• 01: Full - Incremental (f4b3b5ab)
• 00: Full (f4b3b5ab)

[kimbarrett]

Looks good.

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout submit/8295156-improve-constant-other-prediction
git fetch https://git.openjdk.org/jdk master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@tschatzl this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout submit/8295156-improve-constant-other-prediction
git fetch https://git.openjdk.org/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295156: G1: Improve constant other time calculation

Co-authored-by: Ivan Walulya <iwalulya@openjdk.org>
Reviewed-by: kbarrett, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tschatzl]

Thanks @kimbarrett @walulyai for your reviews.

/integrate

[openjdk]

Going to push as commit 312985e.
Since your change was applied there has been 1 commit pushed to the master branch:

• 786ce1c: 8295024: Cyclic constructor error is non-deterministic and inconsistent

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit 312985e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.