8288415: java/awt/PopupMenu/PopupMenuLocation.java is unstable in MacOS machines

[manukumarvs]

java/awt/PopupMenu/PopupMenuLocation.java seems to be unstable in MacOS machines, especially in MacOSX 12 & 13 machines. It seems to be a testbug as adding some stability improvements fixes the issue. It intermittently fails in CI causing some noise. This test was already problem listed in windows due to an umbrella bug JDK-8238720. This fix doesn't cover the Windows issue, so the problem listing in windows will remain same.

Fix:
Some stability improvements have been done and the test has been run 100 times per platform in mach5 and got full PASS.
Also updated the screen capture code, made frame undecorated, added some prints for better debugging.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8288415: java/awt/PopupMenu/PopupMenuLocation.java is unstable in MacOS machines

Reviewers

• Damon Nguyen (@DamonGuy - Author)
• Alexey Ivanov (@aivanov-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10655/head:pull/10655
$ git checkout pull/10655

Update a local copy of the PR:
$ git checkout pull/10655
$ git pull https://git.openjdk.org/jdk pull/10655/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10655

View PR using the GUI difftool:
$ git pr show -t 10655

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10655.diff

[bridgekeeper]

👋 Welcome back mvs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@manukumarvs The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (fe4f9bb4)
• 01: Full - Incremental (b3ac566d)
• 00: Full (5b33a645)

[SWinxy]

So, what's the difference between this and #9187 and #10606? And did one of them have git issues?

[manukumarvs]

So, what's the difference between this and #9187 and #10606? And did one of them have git issues?

No, #9187 got closed automatically by bot after being inactive for 8 weeks. And difference between #9187 and #10606 are,

1. Improved the screen capture logic in 8288415: java/awt/PopupMenu/PopupMenuLocation.java is unstable in MacOS machines #10606 to capture the corresponding screen where the frame is displayed.
2. Made the frame undecorated as I have seen in some linux machines that, sometimes the mouse click inadvertently goes to the frame header which in turn fails the test(as it will not invoke the popup menu).

[manukumarvs]

Any volunteers please.

[manukumarvs]

Any volunteers for a review?.

[DamonGuy]

I ran the updated test in CI and locally, and it seems to be OK. My issue is that when I run locally, the test takes noticeably longer to execute and complete. I tried investigating the issue by implementing your changes incrementally, and I believe it's due to the waitForIdle after button3 presses. Maybe it's better to place a set amount of delay in ms here instead? Additionally, there are multiple spacing issues in the updated lines, and the header needs to be updated to have "2022" alongside the "2017" test date.

[bridgekeeper]

@manukumarvs This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[aivanov-jdk]

I also suggest removing the second asterisk at line 43, so that jtreg tags don't result javadoc warnings.

If you also remove throws Exception clause from openPopup, the test will become warning-free.

[manukumarvs]

I also suggest removing the second asterisk at line 43, so that jtreg tags don't result javadoc warnings.

If you also remove throws Exception clause from openPopup, the test will become warning-free.

Fixed the review comments and updated the test.

[manukumarvs]

Accidentally closed the PR, reopening it.

[openjdk]

@manukumarvs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288415: java/awt/PopupMenu/PopupMenuLocation.java is unstable in MacOS machines

Reviewed-by: dnguyen, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1278 new commits pushed to the master branch:

• a734285: 8299879: CollectedHeap hierarchy should use override
• 98d75f1: 8299038: Add AArch64 backend support for auto-vectorized FP16 conversions
• cac72a6: 8300053: Shenandoah: Handle more GCCauses in ShenandoahControlThread::request_gc
• 6fea233: 8299960: Speed up test/hotspot/jtreg/compiler/c2/irTests/TestVectorizeURShiftSubword.java
• 7c1ebcc: 8299962: Speed up compiler/intrinsics/unsafe/DirectByteBufferTest.java and HeapByteBufferTest.java
• abfd7e8: 8300113: C2: Single-bit fields with signed type in TypePtr after JDK-8297933
• 83f2c9a: 8293410: Remove GenerateRangeChecks flag
• 50e7df9: 8300024: Replace use of JNI_COMMIT mode with mode 0
• fe7fca0: 8300032: DwarfParser resource leak
• 12edd6f: 8300052: PdhDll::PdhCollectQueryData and PdhLookupPerfNameByIndex will never be NULL
• ... and 1268 more: https://git.openjdk.org/jdk/compare/9d0009e92b790b43153e3db353db775e6ff731cb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[DamonGuy]

Looks good. My main concern was the really long delay from waitForIdle. Glad a bug was raised for that and all of the minor issues were addressed.

[manukumarvs]

/integrate

[openjdk]

@manukumarvs
Your change (at version fe4f9bb) is now ready to be sponsored by a Committer.

[aivanov-jdk]

/sponsor

[openjdk]

Going to push as commit a2f6766.
Since your change was applied there have been 1278 commits pushed to the master branch:

• a734285: 8299879: CollectedHeap hierarchy should use override
• 98d75f1: 8299038: Add AArch64 backend support for auto-vectorized FP16 conversions
• cac72a6: 8300053: Shenandoah: Handle more GCCauses in ShenandoahControlThread::request_gc
• 6fea233: 8299960: Speed up test/hotspot/jtreg/compiler/c2/irTests/TestVectorizeURShiftSubword.java
• 7c1ebcc: 8299962: Speed up compiler/intrinsics/unsafe/DirectByteBufferTest.java and HeapByteBufferTest.java
• abfd7e8: 8300113: C2: Single-bit fields with signed type in TypePtr after JDK-8297933
• 83f2c9a: 8293410: Remove GenerateRangeChecks flag
• 50e7df9: 8300024: Replace use of JNI_COMMIT mode with mode 0
• fe7fca0: 8300032: DwarfParser resource leak
• 12edd6f: 8300052: PdhDll::PdhCollectQueryData and PdhLookupPerfNameByIndex will never be NULL
• ... and 1268 more: https://git.openjdk.org/jdk/compare/9d0009e92b790b43153e3db353db775e6ff731cb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@aivanov-jdk @manukumarvs Pushed as commit a2f6766.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.