-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8295163: Remove old hsdis Makefile #10660
Conversation
👋 Welcome back ihse! A progress list of the required criteria for merging this PR into |
/label remove hotspot-compiler |
@magicus |
@magicus This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit e1a77cf.
Your commit was automatically rebased without conflicts. |
For some reason the old Makefile for hsdis was not removed when the build was moved into the normal build system in JDK-8188073. This should be fixed.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10660/head:pull/10660
$ git checkout pull/10660
Update a local copy of the PR:
$ git checkout pull/10660
$ git pull https://git.openjdk.org/jdk pull/10660/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10660
View PR using the GUI difftool:
$ git pr show -t 10660
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10660.diff