Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292386: jvmti/thread/SuspendThread/suspendthrd03 failed with "FAIL: Status is 2" #10662

Closed
wants to merge 1 commit into from

Conversation

lmesnik
Copy link
Member

@lmesnik lmesnik commented Oct 11, 2022

This test duplicates runtime/handshake/HandshakeSuspendExitTest.java and might be deleted.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292386: jvmti/thread/SuspendThread/suspendthrd03 failed with "FAIL: Status is 2"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10662/head:pull/10662
$ git checkout pull/10662

Update a local copy of the PR:
$ git checkout pull/10662
$ git pull https://git.openjdk.org/jdk pull/10662/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10662

View PR using the GUI difftool:
$ git pr show -t 10662

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10662.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 11, 2022

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 11, 2022
@openjdk
Copy link

openjdk bot commented Oct 11, 2022

@lmesnik The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Oct 11, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 11, 2022

Webrevs

Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, the failing status is a test issue but it is hard to prove.
This test is over complicated and hard to understand and work with.
Additionally, it duplicates matching nsk test: suspendthrd003.
It is nice to remove it. We already have enough test coverage in this area.
Thanks,
Serguei

@openjdk
Copy link

openjdk bot commented Oct 11, 2022

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292386: jvmti/thread/SuspendThread/suspendthrd03 failed with "FAIL: Status is 2"

Reviewed-by: sspitsyn, dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • d362e16: 8294689: The SA transported_core.html file needs quite a bit of work
  • 07946aa: 8289552: Make intrinsic conversions between bit representations of half precision values and floats
  • 2586b1a: 8295155: Incorrect javadoc of java.base module
  • e1a77cf: 8295163: Remove old hsdis Makefile
  • 3c7ae12: 8294821: Class load improvement for AES crypto engine

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 11, 2022
@dcubed-ojdk
Copy link
Member

I don't think that this test:

serviceability/jvmti/thread/SuspendThread/suspendthrd03/suspendthrd03.java

duplicates:

runtime/handshake/HandshakeSuspendExitTest.java

It appears to be a ported test based on this test:

test/hotspot/jtreg/vmTestbase/nsk/jvmti/SuspendThread/suspendthrd003.java
test/hotspot/jtreg/vmTestbase/nsk/jvmti/SuspendThread/suspendthrd003/suspendthrd003.cpp
test/hotspot/jtreg/vmTestbase/nsk/jvmti/SuspendThread/suspendthrd003/TestDescription.java

I'm pretty sure that I added vmTestbase/nsk/jvmti/SuspendThread/suspendthrd003 as
part of my work on Thread-SMR. It looks like this test:

serviceability/jvmti/thread/SuspendThread/suspendthrd03/suspendthrd03.java

was added as part of the Loom project for some reason.

@dcubed-ojdk
Copy link
Member

I'm okay with deleting these two files:

test/hotspot/jtreg/serviceability/jvmti/thread/SuspendThread/suspendthrd03/libsuspendthrd03.cpp
test/hotspot/jtreg/serviceability/jvmti/thread/SuspendThread/suspendthrd03/suspendthrd03.java

but can someone explain why this test was ported/created in the first place?

And did the Loom project do this with other tests and, if so, why?

@lmesnik
Copy link
Member Author

lmesnik commented Oct 11, 2022

I'm okay with deleting these two files:

test/hotspot/jtreg/serviceability/jvmti/thread/SuspendThread/suspendthrd03/libsuspendthrd03.cpp test/hotspot/jtreg/serviceability/jvmti/thread/SuspendThread/suspendthrd03/suspendthrd03.java

but can someone explain why this test was ported/created in the first place?

And did the Loom project do this with other tests and, if so, why?

The idea was to improve these tests to test virtual threads. However, the suspend/resume have already some coverage in vthread. So these tests remain unchanged. Currently, I think it is needed to remove this test and might be simplify nsk/jvmti original.

@sspitsyn
Copy link
Contributor

sspitsyn commented Oct 11, 2022

The idea was to improve these tests to test virtual threads.
However, the suspend/resume have already some coverage in vthread.

In fact, we have pretty extensive SR test coverage for virtual threads.

@lmesnik
Copy link
Member Author

lmesnik commented Oct 12, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 12, 2022

Going to push as commit 0475c34.
Since your change was applied there have been 26 commits pushed to the master branch:

  • 760a260: 8295213: Run GHA manually with user-specified make and configure arguments
  • 8402260: 8295198: Update more openjdk.java.net => openjdk.org URLs
  • c357b59: 8295211: Fix autoconf 2.71 warning "AC_CHECK_HEADERS: you should use literals"
  • 8607842: 8295205: Add jcheck whitespace checking for markdown files
  • cb62f1c: 8295218: New KeepAliveTest.java has invalid copyright notice
  • 9cf6651: 8294238: ZGC: Move CLD claimed mark clearing
  • adaff7d: 8294900: Refactor ZObjArrayAllocator
  • 86ec158: 8291226: Create Test Cases to cover scenarios for JDK-8278067
  • 94ec729: 8263044: jdk/jfr/jvm/TestDumpOnCrash.java timed out
  • bdb4ed0: 8294580: frame::interpreter_frame_print_on() crashes if free BasicObjectLock exists in frame
  • ... and 16 more: https://git.openjdk.org/jdk/compare/619cd825b53465c4d533d5cab70070c08964fa91...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 12, 2022
@openjdk openjdk bot closed this Oct 12, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 12, 2022
@openjdk
Copy link

openjdk bot commented Oct 12, 2022

@lmesnik Pushed as commit 0475c34.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@lmesnik lmesnik deleted the 8292386 branch June 5, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
3 participants