Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8294486: Remove vmTestbase/nsk/jvmti/ tests ported to serviceability/jvmti. #10665

Closed
wants to merge 2 commits into from

Conversation

lmesnik
Copy link
Member

@lmesnik lmesnik commented Oct 11, 2022

The fix removes nsk/jvmti/ tests ported to serviceability/jvmti and forward-ports corresponding fixed. The suspend/resume tests require more work covered by https://bugs.openjdk.org/browse/JDK-8295169.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8294486: Remove vmTestbase/nsk/jvmti/ tests ported to serviceability/jvmti.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10665/head:pull/10665
$ git checkout pull/10665

Update a local copy of the PR:
$ git checkout pull/10665
$ git pull https://git.openjdk.org/jdk pull/10665/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10665

View PR using the GUI difftool:
$ git pr show -t 10665

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10665.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 11, 2022

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 11, 2022
@openjdk
Copy link

openjdk bot commented Oct 11, 2022

@lmesnik The following labels will be automatically applied to this pull request:

  • hotspot
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org hotspot hotspot-dev@openjdk.org labels Oct 11, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 11, 2022

Webrevs

@plummercj
Copy link
Contributor

Can you update the CR to point to the CR that did the porting?

@lmesnik
Copy link
Member Author

lmesnik commented Oct 11, 2022

The tests were ported as a part of Loom. I added tests which are ported to the bug.

@sspitsyn
Copy link
Contributor

A question.
I do not see the following tests deleted while they are deleted from the TEST.qick-groups :

-  vmTestbase/nsk/jvmti/RunAgentThread/agentthr001/TestDescription.java \
-  vmTestbase/nsk/jvmti/RunAgentThread/agentthr001/TestDescription.java \
-  vmTestbase/nsk/jvmti/ThreadEnd/threadend001/TestDescription.java \
-  vmTestbase/nsk/jvmti/ThreadEnd/threadend002/TestDescription.java \

@lmesnik
Copy link
Member Author

lmesnik commented Oct 21, 2022

Thank you, I deleted vmTestbase/nsk/jvmti/ThreadEnd which were ported and returned back RunAgentThread entries.

@sspitsyn
Copy link
Contributor

Thank you for the update. One more question.
A couple of tests are not listed in the test/hotspot/jtreg/TEST.quick-groups:

  test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetFrameLocation/frameloc001
  test/hotspot/jtreg/vmTestbase/nsk/jvmti/SingleStep/singlestep002

Is it because these tests were initially missed to be added into this file?

Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thanks,
Serguei

@openjdk
Copy link

openjdk bot commented Oct 24, 2022

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294486: Remove vmTestbase/nsk/jvmti/ tests ported to serviceability/jvmti.

Reviewed-by: sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 241 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 24, 2022
@lmesnik
Copy link
Member Author

lmesnik commented Oct 24, 2022

Thank you for the update. One more question. A couple of tests are not listed in the test/hotspot/jtreg/TEST.quick-groups:

  test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetFrameLocation/frameloc001
  test/hotspot/jtreg/vmTestbase/nsk/jvmti/SingleStep/singlestep002

Is it because these tests were initially missed to be added into this file?

This file contains only tests which had 'quick' keyword before conversion from tonga. So, they might be just were not supposed to add to quick group.

@sspitsyn
Copy link
Contributor

Okay, thanks.

@lmesnik
Copy link
Member Author

lmesnik commented Oct 25, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 25, 2022

Going to push as commit 3bd3caf.
Since your change was applied there have been 259 commits pushed to the master branch:

  • fec6174: 8295816: jdwp jck tests failing with "FATAL ERROR in native method: JDWP SetTag, jvmtiError=JVMTI_ERROR_WRONG_PHASE(112)"
  • e0c2930: 8295282: Use Zicboz/cbo.zero to zero-out memory on RISC-V
  • d393e05: 8294989: ResourceBundle naming convention issue in JdbcRowSetResourceBundle.java
  • 0caea81: 8295895: build error after JDK-8279366
  • ee0dec8: 8295838: Document why we do not print Code Cache Roots phase in G1 logging
  • ef60608: 8295732: Directly embed TruncatedSeqs in G1Analytics
  • 3e49f8f: 8295839: G1: Single threaded phases (within parallel phases) report as using multiple threads in logs
  • 427f506: 8279366: CDS should allow alternative locations for JAR files in classpath
  • 3a873d3: 8295808: GrowableArray should support capacity management
  • 6289600: 8295810: cleanup debug agent removeThread() api
  • ... and 249 more: https://git.openjdk.org/jdk/compare/d4c9a88073479ff05e6c07ed599c546826d6f6ba...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 25, 2022
@openjdk openjdk bot closed this Oct 25, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 25, 2022
@openjdk
Copy link

openjdk bot commented Oct 25, 2022

@lmesnik Pushed as commit 3bd3caf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@lmesnik lmesnik deleted the 8294486 branch June 5, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
3 participants