Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8291638: Keep-Alive timeout of 0 should close connection immediately #10678

Closed

Conversation

Michael-Mc-Mahon
Copy link
Member

@Michael-Mc-Mahon Michael-Mc-Mahon commented Oct 12, 2022

Hi

Could I get the following change reviewed please? It fixes an issue identified by the new KeepAliveTest test case where a server returned keep-alive "timeout=0" should have closed the connection, but was reverting to the old defaults.

Thanks,
Michael.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8291638: Keep-Alive timeout of 0 should close connection immediately

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10678/head:pull/10678
$ git checkout pull/10678

Update a local copy of the PR:
$ git checkout pull/10678
$ git pull https://git.openjdk.org/jdk pull/10678/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10678

View PR using the GUI difftool:
$ git pr show -t 10678

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10678.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 12, 2022

👋 Welcome back michaelm! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 12, 2022
@openjdk
Copy link

openjdk bot commented Oct 12, 2022

@Michael-Mc-Mahon The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label Oct 12, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 12, 2022

Webrevs

Copy link
Member

@dfuch dfuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Oct 12, 2022

@Michael-Mc-Mahon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8291638: Keep-Alive timeout of 0 should close connection immediately

Reviewed-by: dfuchs, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 90fb9a0: 8295102: Always load @lambda-form-invoker lines from default classlist
  • ac19414: 8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance
  • 1961e81: 8289509: Improve test coverage for XPath Axes: descendant, descendant-or-self, following, following-sibling
  • 5699041: 8294772: Remove workaround in os::dll_address_to_library_name
  • d125265: 8277970: Test jdk/sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java fails with "tag mismatch"
  • 0475c34: 8292386: jvmti/thread/SuspendThread/suspendthrd03 failed with "FAIL: Status is 2"
  • 760a260: 8295213: Run GHA manually with user-specified make and configure arguments
  • 8402260: 8295198: Update more openjdk.java.net => openjdk.org URLs
  • c357b59: 8295211: Fix autoconf 2.71 warning "AC_CHECK_HEADERS: you should use literals"
  • 8607842: 8295205: Add jcheck whitespace checking for markdown files

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 12, 2022
Copy link
Member

@dfuch dfuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh - maybe trivially update the copyright years in HeaderParser.java before pushing

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Oct 12, 2022
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 12, 2022
@Michael-Mc-Mahon
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 13, 2022

Going to push as commit 26ac836.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 6ae7e4d: 8293984: Unnecessary Vector usage in PropertyEditorSupport
  • cd1357b: 8295229: Try to verify gtest version
  • 90fb9a0: 8295102: Always load @lambda-form-invoker lines from default classlist
  • ac19414: 8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance
  • 1961e81: 8289509: Improve test coverage for XPath Axes: descendant, descendant-or-self, following, following-sibling
  • 5699041: 8294772: Remove workaround in os::dll_address_to_library_name
  • d125265: 8277970: Test jdk/sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java fails with "tag mismatch"
  • 0475c34: 8292386: jvmti/thread/SuspendThread/suspendthrd03 failed with "FAIL: Status is 2"
  • 760a260: 8295213: Run GHA manually with user-specified make and configure arguments
  • 8402260: 8295198: Update more openjdk.java.net => openjdk.org URLs
  • ... and 2 more: https://git.openjdk.org/jdk/compare/cb62f1c5c0dd0d2a1570bace3c494a5c0c2b06b8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 13, 2022
@openjdk openjdk bot closed this Oct 13, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 13, 2022
@openjdk
Copy link

openjdk bot commented Oct 13, 2022

@Michael-Mc-Mahon Pushed as commit 26ac836.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Michael-Mc-Mahon Michael-Mc-Mahon deleted the keepAliveUpdate branch October 13, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net net-dev@openjdk.org
3 participants