8282958: Rendering issues of borders, TextFields on Windows High-DPI systems #10681

rajamah · 2022-10-12T16:41:52Z

This fix is based on a similar approach as described here #7449 (comment).
We rescale the line border to render the Textfield border correctly, so that all sides of the Textfield border are of same thickness.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8282958: Rendering issues of borders, TextFields on Windows High-DPI systems

Reviewers

Alexey Ivanov (@aivanov-jdk - Reviewer)
Harshitha Onkar (@honkar-jdk - Author) ⚠️ Review applies to 0e8fb4e7
Alexander Zuev (@azuev-java - Reviewer)

Contributors

Alexey Ivanov <aivanov@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10681/head:pull/10681
$ git checkout pull/10681

Update a local copy of the PR:
$ git checkout pull/10681
$ git pull https://git.openjdk.org/jdk pull/10681/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10681

View PR using the GUI difftool:
$ git pr show -t 10681

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10681.diff

…systems This fix is based on a similar approach as described here openjdk#7449 (comment). We rescale the line border to render the textfield border correctly, so that all sides of the textfield border are of same thickness.

rajamah · 2022-10-12T16:42:50Z

/contributor add aivanov

bridgekeeper · 2022-10-12T16:43:52Z

👋 Welcome back rajamah! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-10-12T16:47:21Z

@rajamah
Contributor Alexey Ivanov <aivanov@openjdk.org> successfully added.

openjdk · 2022-10-12T16:49:31Z

@rajamah The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-10-13T16:32:17Z

Webrevs

aivanov-jdk

Looks good to me.

test/jdk/javax/swing/border/LineBorder/ScaledLineBorderTest.java

openjdk · 2022-10-27T19:48:54Z

@rajamah This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282958: Rendering issues of borders, TextFields on Windows High-DPI systems

Co-authored-by: Alexey Ivanov <aivanov@openjdk.org>
Reviewed-by: aivanov, honkar, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 268 new commits pushed to the master branch:

2fb64a4: 8296162: [aarch64] Remove unused Address::_is_lval
15b8b45: 8296161: [aarch64] Remove unused "pcrel" addressing mode tag
f829b5a: 8280378: [IR Framework] Support IR matching for different compile phases
da0ae51: 8296167: test/langtools/tools/jdeps/jdkinternals/ShowReplacement.java failing after JDK-8296072
0d0bd7b: 8296072: CertAttrSet::encode and DerEncoder::derEncode should write into DerOutputStream
37107fc: 8296007: crash in runtime/DefineClass/NullClassBytesTest.java
4999f2c: 8156593: DataOutput.write(byte[],int,int) and its implementations do not specify index out bounds
8480f87: 8291974: PrivateCredentialPermission should not use local variable to enable debugging
590de37: 8284842: Update Unicode Data Files to Version 15.0.0
16744b3: 8256660: Disable DTLS 1.0
... and 258 more: https://git.openjdk.org/jdk/compare/3c7ae1225f0d5575fd927a9b76fb40dc30e208cd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk, @azuev-java) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Co-authored-by: Alexey Ivanov <alexey.ivanov@oracle.com>

honkar-jdk

Checked the saved images on paint.net, the border thickness is equal and uniform on 4 sides (no. of pixels painted) for different scales.

Copyright year needs to be updated for LineBorder.

azuev-java

Looks good to me.

rajamah · 2022-11-01T18:08:05Z

/integrate

openjdk · 2022-11-01T18:10:07Z

@rajamah
Your change (at version 815b0d7) is now ready to be sponsored by a Committer.

aivanov-jdk · 2022-11-01T18:36:08Z

/sponsor

openjdk · 2022-11-01T18:38:13Z

Going to push as commit 9911405.
Since your change was applied there have been 268 commits pushed to the master branch:

2fb64a4: 8296162: [aarch64] Remove unused Address::_is_lval
15b8b45: 8296161: [aarch64] Remove unused "pcrel" addressing mode tag
f829b5a: 8280378: [IR Framework] Support IR matching for different compile phases
da0ae51: 8296167: test/langtools/tools/jdeps/jdkinternals/ShowReplacement.java failing after JDK-8296072
0d0bd7b: 8296072: CertAttrSet::encode and DerEncoder::derEncode should write into DerOutputStream
37107fc: 8296007: crash in runtime/DefineClass/NullClassBytesTest.java
4999f2c: 8156593: DataOutput.write(byte[],int,int) and its implementations do not specify index out bounds
8480f87: 8291974: PrivateCredentialPermission should not use local variable to enable debugging
590de37: 8284842: Update Unicode Data Files to Version 15.0.0
16744b3: 8256660: Disable DTLS 1.0
... and 258 more: https://git.openjdk.org/jdk/compare/3c7ae1225f0d5575fd927a9b76fb40dc30e208cd...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-11-01T18:38:34Z

@aivanov-jdk @rajamah Pushed as commit 9911405.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk bot added the client client-libs-dev@openjdk.org label Oct 12, 2022

rajamah added 2 commits October 12, 2022 09:51

fix file ending

f3cae97

remove executable permission

4fca847

openjdk bot added the rfr Pull request is ready for review label Oct 13, 2022

aivanov-jdk approved these changes Oct 27, 2022

View reviewed changes

test/jdk/javax/swing/border/LineBorder/ScaledLineBorderTest.java Outdated Show resolved Hide resolved

openjdk bot added the ready Pull request is ready to be integrated label Oct 27, 2022

Update test/jdk/javax/swing/border/LineBorder/ScaledLineBorderTest.java

0e8fb4e

Co-authored-by: Alexey Ivanov <alexey.ivanov@oracle.com>

aivanov-jdk approved these changes Oct 28, 2022

View reviewed changes

honkar-jdk suggested changes Nov 1, 2022

View reviewed changes

honkar-jdk approved these changes Nov 1, 2022

View reviewed changes

updated copyright year

815b0d7

azuev-java approved these changes Nov 1, 2022

View reviewed changes

aivanov-jdk approved these changes Nov 1, 2022

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 1, 2022

openjdk bot added the integrated Pull request has been integrated label Nov 1, 2022

openjdk bot closed this Nov 1, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 1, 2022

aivanov-jdk mentioned this pull request Nov 4, 2022

JDK-8015739: Background of JInternalFrame is located out of JInternalFrame #10274

Closed

3 tasks

honkar-jdk mentioned this pull request Dec 7, 2022

JDK-8294680: Refactor scaled border rendering #11571

Closed

3 tasks

aivanov-jdk mentioned this pull request Jun 28, 2025

8349188: LineBorder does not scale correctly #26025

Closed

3 tasks

8282958: Rendering issues of borders, TextFields on Windows High-DPI systems #10681

8282958: Rendering issues of borders, TextFields on Windows High-DPI systems #10681

Uh oh!

Conversation

rajamah commented Oct 12, 2022 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Contributors

Reviewing

Uh oh!

rajamah commented Oct 12, 2022

Uh oh!

bridgekeeper bot commented Oct 12, 2022

Uh oh!

openjdk bot commented Oct 12, 2022

Uh oh!

openjdk bot commented Oct 12, 2022

Uh oh!

mlbridge bot commented Oct 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

aivanov-jdk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

openjdk bot commented Oct 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

honkar-jdk left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

azuev-java left a comment

Choose a reason for hiding this comment

Uh oh!

rajamah commented Nov 1, 2022

Uh oh!

openjdk bot commented Nov 1, 2022

Uh oh!

aivanov-jdk commented Nov 1, 2022

Uh oh!

openjdk bot commented Nov 1, 2022

Uh oh!

openjdk bot commented Nov 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

rajamah commented Oct 12, 2022 •

edited by openjdk bot

Loading

mlbridge bot commented Oct 13, 2022 •

edited

Loading

openjdk bot commented Oct 27, 2022 •

edited

Loading

honkar-jdk left a comment •

edited

Loading